Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 2215623002: Subzero: More documentation for the NACLENV arg passthrough mechanism. (Closed)

Created:
4 years, 4 months ago by Jim Stichnoth
Modified:
4 years, 4 months ago
Reviewers:
Eric Holk, Karl, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: More documentation for the NACLENV arg passthrough mechanism. BUG= none Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=a64156e863885059cf21f2673b9341e87ebd367d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/IceBrowserCompileServer.cpp View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
4 years, 4 months ago (2016-08-04 06:40:29 UTC) #3
Jim Stichnoth
Committed patchset #1 (id:1) manually as a64156e863885059cf21f2673b9341e87ebd367d (presubmit successful).
4 years, 4 months ago (2016-08-08 21:25:57 UTC) #5
John
4 years, 4 months ago (2016-08-08 21:27:15 UTC) #6
Message was sent while issue was closed.
lgtm

this slipped through the cracks... sorry

Powered by Google App Engine
This is Rietveld 408576698