Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: src/IceBrowserCompileServer.cpp

Issue 2215623002: Subzero: More documentation for the NACLENV arg passthrough mechanism. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceBrowserCompileServer.cpp
diff --git a/src/IceBrowserCompileServer.cpp b/src/IceBrowserCompileServer.cpp
index 8b94a977250d1d151b24f4485453d98f6a85e78e..ab2d69fd2cb2b50e5cc500a2ee0204718b46c98c 100644
--- a/src/IceBrowserCompileServer.cpp
+++ b/src/IceBrowserCompileServer.cpp
@@ -53,6 +53,9 @@ void getIRTInterfaces() {
// Allow pnacl-sz arguments to be supplied externally, instead of coming from
// the browser. This is meant to be used for debugging.
//
+// NOTE: This functionality is only enabled in non-MINIMAL Subzero builds, for
+// security/safety reasons.
+//
// If the SZARGFILE environment variable is set to a file name, arguments are
// read from that file, one argument per line. This requires setting 3
// environment variables before starting the browser:
@@ -78,6 +81,12 @@ void getIRTInterfaces() {
// ignored, to allow -threads to be specified as an external argument. Note
// that the browser normally supplies the "-O2" argument, so externally supplied
// arguments might want to provide an explicit -O argument.
+//
+// See Chrome's src/components/nacl/zygote/nacl_fork_delegate_linux.cc for the
+// NACL_ENV_PASSTHROUGH mechanism.
+//
+// See NaCl's src/trusted/service_runtime/env_cleanser.c for the NACLENV_
+// mechanism.
std::vector<std::string> getExternalArgs() {
std::vector<std::string> ExternalArgs;
if (BuildDefs::minimal())
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698