Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2215353004: content: Let embedders know when MojoShellConnection is initialized. (Closed)

Created:
4 years, 4 months ago by sadrul
Modified:
4 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Let embedders know when MojoShellConnection is initialized. Introduce BrowserMainParts::MojoShellConnectionStarted() to let the embedder know when connection to the mojo shell has been started. Chrome uses this notification to set up its connection to the ui service when running as a mus client. BUG=none Committed: https://crrev.com/a15cfccb86111ac1bb1d61da33e8d5789fdf3cbf Cr-Commit-Position: refs/heads/master@{#410392}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -44 lines) Patch
M chrome/browser/chrome_browser_main.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main_extra_parts.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc View 1 2 chunks +13 lines, -9 lines 0 comments Download
M content/browser/browser_main_loop.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 3 chunks +28 lines, -34 lines 0 comments Download
M content/public/browser/browser_main_parts.h View 1 2 chunks +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (14 generated)
sadrul
Setting up the connection to mus in chrome earlier than it happens now would make ...
4 years, 4 months ago (2016-08-05 17:41:15 UTC) #9
sadrul
+jam@ would you please take a look at the change in BrowserMainParts and ChromeBrowserMainExtraParts interfaces? ...
4 years, 4 months ago (2016-08-05 19:08:35 UTC) #13
Ken Rockot(use gerrit already)
lgtm as non owner
4 years, 4 months ago (2016-08-05 19:13:47 UTC) #14
Ben Goodger (Google)
lgtm
4 years, 4 months ago (2016-08-05 20:35:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2215353004/20001
4 years, 4 months ago (2016-08-08 17:14:58 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-08 18:04:22 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 18:07:48 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a15cfccb86111ac1bb1d61da33e8d5789fdf3cbf
Cr-Commit-Position: refs/heads/master@{#410392}

Powered by Google App Engine
This is Rietveld 408576698