src/gpu/vk/GrVkGpu.cpp - Issue 2215353003: Fix vulkan resolve

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/vk/GrVkGpu.cpp

Issue 2215353003: Fix vulkan resolve (Closed) Base URL: https://skia.googlesource.com/skia.git@resolveCmd

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/vk/GrVkGpu.cpp

diff --git a/src/gpu/vk/GrVkGpu.cpp b/src/gpu/vk/GrVkGpu.cpp

index 8e204446a2633d3ebede04dd1806dc6321f58bcd..85bfce87679c696ba720e6ff84f6747a5207b6d2 100644

--- a/src/gpu/vk/GrVkGpu.cpp

+++ b/src/gpu/vk/GrVkGpu.cpp

@@ -366,9 +366,7 @@ bool GrVkGpu::onWritePixels(GrSurface* surface,

}

void GrVkGpu::onResolveRenderTarget(GrRenderTarget* target) {

- if (target->needsResolve()) {

- SkASSERT(target->numColorSamples() > 1);

+ if (target->needsResolve() && target->numColorSamples() > 1) {

GrVkRenderTarget* rt = static_cast<GrVkRenderTarget*>(target);

SkASSERT(rt->msaaImage());

« no previous file with comments | « no previous file | no next file » | no next file with comments »