third_party/WebKit/Source/web/PopupMenuImpl.cpp - Issue 2215333002: Fix element visibility check for validation bubbles and SELECT popups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/PopupMenuImpl.cpp

Issue 2215333002: Fix element visibility check for validation bubbles and SELECT popups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename to visibleBoundsInVisualViewport(), etc. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp ('k') | third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/PopupMenuImpl.cpp

diff --git a/third_party/WebKit/Source/web/PopupMenuImpl.cpp b/third_party/WebKit/Source/web/PopupMenuImpl.cpp

index 76677ef4865ade6a31b9727cdb4f5c6db53f7755..7ee847eb08de3deb0cbe8c5136ece53427cddc4d 100644

--- a/third_party/WebKit/Source/web/PopupMenuImpl.cpp

+++ b/third_party/WebKit/Source/web/PopupMenuImpl.cpp

@@ -246,7 +246,7 @@ DEFINE_TRACE(PopupMenuImpl)

void PopupMenuImpl::writeDocument(SharedBuffer* data)

{

HTMLSelectElement& ownerElement = *m_ownerElement;

- IntRect anchorRectInScreen = m_chromeClient->viewportToScreen(ownerElement.elementRectRelativeToViewport(), ownerElement.document().view());

+ IntRect anchorRectInScreen = m_chromeClient->viewportToScreen(ownerElement.visibleBoundsInVisualViewport(), ownerElement.document().view());

PagePopupClient::addString("<!DOCTYPE html><head><meta charset='UTF-8'><style>\n", data);

data->append(Platform::current()->loadResource("pickerCommon.css"));

@@ -511,7 +511,7 @@ void PopupMenuImpl::update()

}

context.finishGroupIfNecessary();

PagePopupClient::addString("],\n", data.get());

- IntRect anchorRectInScreen = m_chromeClient->viewportToScreen(m_ownerElement->elementRectRelativeToViewport(), ownerElement().document().view());

+ IntRect anchorRectInScreen = m_chromeClient->viewportToScreen(m_ownerElement->visibleBoundsInVisualViewport(), ownerElement().document().view());

addProperty("anchorRectInScreen", anchorRectInScreen, data.get());

PagePopupClient::addString("}\n", data.get());

m_popup->postMessage(String::fromUTF8(data->data(), data->size()));