Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp

Issue 2215333002: Fix element visibility check for validation bubbles and SELECT popups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename to visibleBoundsInVisualViewport(), etc. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp b/third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp
index 135cbe15185b81f6fc4b94e38e46f2ac4286df35..b14fd976c2e9b8b06b3b67df1b6b67e454ae58fe 100644
--- a/third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp
@@ -133,13 +133,13 @@ TEST_F(HTMLSelectElementTest, RestoreUnmatchedFormControlState)
EXPECT_EQ(nullptr, toHTMLSelectElement(element)->optionToBeShown());
}
-TEST_F(HTMLSelectElementTest, ElementRectRelativeToViewport)
+TEST_F(HTMLSelectElementTest, VisibleBoundsInVisualViewport)
{
document().documentElement()->setInnerHTML("<select style='position:fixed; top:12.3px; height:24px; -webkit-appearance:none;'><option>o1</select>", ASSERT_NO_EXCEPTION);
document().view()->updateAllLifecyclePhases();
HTMLSelectElement* select = toHTMLSelectElement(document().body()->firstChild());
ASSERT(select);
- IntRect bounds = select->elementRectRelativeToViewport();
+ IntRect bounds = select->visibleBoundsInVisualViewport();
EXPECT_EQ(24, bounds.height());
}
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLSelectElement.cpp ('k') | third_party/WebKit/Source/web/PopupMenuImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698