third_party/WebKit/Source/core/html/HTMLSelectElement.h - Issue 2215333002: Fix element visibility check for validation bubbles and SELECT popups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.h

Issue 2215333002: Fix element visibility check for validation bubbles and SELECT popups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename to visibleBoundsInVisualViewport(), etc. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLSelectElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.h b/third_party/WebKit/Source/core/html/HTMLSelectElement.h

index 08d0bb729221a21bd0c35e623f104b4f613f9516..502e4e1b5f82935fb63c6fe0d18b0c5960099aac 100644

--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.h

@@ -144,7 +144,6 @@ public:

// itemComputedStyle() returns nullptr only if the owner Document is not

// active. So, It returns a valid object when we open a popup.

const ComputedStyle* itemComputedStyle(Element&) const;

- IntRect elementRectRelativeToViewport() const;

// Text starting offset in LTR.

LayoutUnit clientPaddingLeft() const;

// Text starting offset in RTL.

« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.cpp ('k') | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »