Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.h

Issue 2215333002: Fix element visibility check for validation bubbles and SELECT popups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename to visibleBoundsInVisualViewport(), etc. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2000 Dirk Mueller (mueller@kde.org) 5 * (C) 2000 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 void handleMouseRelease(); 137 void handleMouseRelease();
138 138
139 int listIndexForOption(const HTMLOptionElement&); 139 int listIndexForOption(const HTMLOptionElement&);
140 140
141 // Helper functions for popup menu implementations. 141 // Helper functions for popup menu implementations.
142 String itemText(const Element&) const; 142 String itemText(const Element&) const;
143 bool itemIsDisplayNone(Element&) const; 143 bool itemIsDisplayNone(Element&) const;
144 // itemComputedStyle() returns nullptr only if the owner Document is not 144 // itemComputedStyle() returns nullptr only if the owner Document is not
145 // active. So, It returns a valid object when we open a popup. 145 // active. So, It returns a valid object when we open a popup.
146 const ComputedStyle* itemComputedStyle(Element&) const; 146 const ComputedStyle* itemComputedStyle(Element&) const;
147 IntRect elementRectRelativeToViewport() const;
148 // Text starting offset in LTR. 147 // Text starting offset in LTR.
149 LayoutUnit clientPaddingLeft() const; 148 LayoutUnit clientPaddingLeft() const;
150 // Text starting offset in RTL. 149 // Text starting offset in RTL.
151 LayoutUnit clientPaddingRight() const; 150 LayoutUnit clientPaddingRight() const;
152 void selectOptionByPopup(int listIndex); 151 void selectOptionByPopup(int listIndex);
153 void selectMultipleOptionsByPopup(const Vector<int>& listIndices); 152 void selectMultipleOptionsByPopup(const Vector<int>& listIndices);
154 // A popup is canceled when the popup was hidden without selecting an item. 153 // A popup is canceled when the popup was hidden without selecting an item.
155 void popupDidCancel(); 154 void popupDidCancel();
156 // Provisional selection is a selection made using arrow keys or type ahead. 155 // Provisional selection is a selection made using arrow keys or type ahead.
157 void provisionalSelectionChanged(unsigned); 156 void provisionalSelectionChanged(unsigned);
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 293
295 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, FirstSelectableOption); 294 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, FirstSelectableOption);
296 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, LastSelectableOption); 295 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, LastSelectableOption);
297 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, NextSelectableOption); 296 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, NextSelectableOption);
298 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, PreviousSelectableOption); 297 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, PreviousSelectableOption);
299 }; 298 };
300 299
301 } // namespace blink 300 } // namespace blink
302 301
303 #endif // HTMLSelectElement_h 302 #endif // HTMLSelectElement_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.cpp ('k') | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698