Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: third_party/WebKit/Source/core/dom/Element.h

Issue 2215333002: Fix element visibility check for validation bubbles and SELECT popups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Element.h
diff --git a/third_party/WebKit/Source/core/dom/Element.h b/third_party/WebKit/Source/core/dom/Element.h
index 2ee3878ade8d7486c5daf15b69b4fe0a05427af6..d6b8b6978a87d976e6d5141d6a4d9d67e70b0d09 100644
--- a/third_party/WebKit/Source/core/dom/Element.h
+++ b/third_party/WebKit/Source/core/dom/Element.h
@@ -220,6 +220,10 @@ public:
virtual void scrollTo(const ScrollToOptions&);
IntRect boundsInViewport() const;
+ // Returns an intersection rectangle of the bounds rectangle and the
+ // viewport rectangle, in the viewport coordinate. This function is used to
bokan 2016/08/08 15:22:59 s/viewport/visual viewport
tkent 2016/08/09 03:17:12 Done.
+ // show popups besides this elment.
bokan 2016/08/08 15:22:59 Nit: besides->beside
tkent 2016/08/09 03:17:12 Done. Also, elment -> element
+ IntRect visibleBoundsInViewport() const;
bokan 2016/08/08 15:22:59 "viewport" is ambiguous. Please call this visibleB
tkent 2016/08/09 03:17:12 Done.
ClientRectList* getClientRects();
ClientRect* getBoundingClientRect();

Powered by Google App Engine
This is Rietveld 408576698