Chromium Code Reviews Chromium Code Reviews
Issue 2215333002:
Fix element visibility check for validation bubbles and SELECT popups. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) | 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) |
| 3 * (C) 1999 Antti Koivisto (koivisto@kde.org) | 3 * (C) 1999 Antti Koivisto (koivisto@kde.org) |
| 4 * (C) 2001 Peter Kelly (pmk@post.com) | 4 * (C) 2001 Peter Kelly (pmk@post.com) |
| 5 * (C) 2001 Dirk Mueller (mueller@kde.org) | 5 * (C) 2001 Dirk Mueller (mueller@kde.org) |
| 6 * Copyright (C) 2003-2011, 2013, 2014 Apple Inc. All rights reserved. | 6 * Copyright (C) 2003-2011, 2013, 2014 Apple Inc. All rights reserved. |
| 7 * | 7 * |
| 8 * This library is free software; you can redistribute it and/or | 8 * This library is free software; you can redistribute it and/or |
| 9 * modify it under the terms of the GNU Library General Public | 9 * modify it under the terms of the GNU Library General Public |
| 10 * License as published by the Free Software Foundation; either | 10 * License as published by the Free Software Foundation; either |
| (...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 213 void setScrollTop(double); | 213 void setScrollTop(double); |
| 214 int scrollWidth(); | 214 int scrollWidth(); |
| 215 int scrollHeight(); | 215 int scrollHeight(); |
| 216 | 216 |
| 217 void scrollBy(double x, double y); | 217 void scrollBy(double x, double y); |
| 218 virtual void scrollBy(const ScrollToOptions&); | 218 virtual void scrollBy(const ScrollToOptions&); |
| 219 void scrollTo(double x, double y); | 219 void scrollTo(double x, double y); |
| 220 virtual void scrollTo(const ScrollToOptions&); | 220 virtual void scrollTo(const ScrollToOptions&); |
| 221 | 221 |
| 222 IntRect boundsInViewport() const; | 222 IntRect boundsInViewport() const; |
| 223 // Returns an intersection rectangle of the bounds rectangle and the | |
| 224 // viewport rectangle, in the viewport coordinate. This function is used to | |
|
bokan
2016/08/08 15:22:59
s/viewport/visual viewport
tkent
2016/08/09 03:17:12
Done.
| |
| 225 // show popups besides this elment. | |
|
bokan
2016/08/08 15:22:59
Nit: besides->beside
tkent
2016/08/09 03:17:12
Done. Also, elment -> element
| |
| 226 IntRect visibleBoundsInViewport() const; | |
|
bokan
2016/08/08 15:22:59
"viewport" is ambiguous. Please call this visibleB
tkent
2016/08/09 03:17:12
Done.
| |
| 223 | 227 |
| 224 ClientRectList* getClientRects(); | 228 ClientRectList* getClientRects(); |
| 225 ClientRect* getBoundingClientRect(); | 229 ClientRect* getBoundingClientRect(); |
| 226 | 230 |
| 227 bool hasNonEmptyLayoutSize() const; | 231 bool hasNonEmptyLayoutSize() const; |
| 228 | 232 |
| 229 const AtomicString& computedRole(); | 233 const AtomicString& computedRole(); |
| 230 String computedName(); | 234 String computedName(); |
| 231 | 235 |
| 232 void didMoveToNewDocument(Document&) override; | 236 void didMoveToNewDocument(Document&) override; |
| (...skipping 749 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 982 static T* create(const QualifiedName&, Document&) | 986 static T* create(const QualifiedName&, Document&) |
| 983 #define DEFINE_ELEMENT_FACTORY_WITH_TAGNAME(T) \ | 987 #define DEFINE_ELEMENT_FACTORY_WITH_TAGNAME(T) \ |
| 984 T* T::create(const QualifiedName& tagName, Document& document) \ | 988 T* T::create(const QualifiedName& tagName, Document& document) \ |
| 985 { \ | 989 { \ |
| 986 return new T(tagName, document); \ | 990 return new T(tagName, document); \ |
| 987 } | 991 } |
| 988 | 992 |
| 989 } // namespace blink | 993 } // namespace blink |
| 990 | 994 |
| 991 #endif // Element_h | 995 #endif // Element_h |
| OLD | NEW |
