DevTools: do not use CSSMetadata instances for autocompletion

DevTools: do not use CSSMetadata instances for autocompletion

The WI.CSSMetadata should serve a single purpose: hold meta-information about CSS properties.

However, today WI.CSSMetadata also provides an API for CSS property autocompletion in
Styles sidebar and Source frame. There's no good reason for that.

BUG=none

Committed: https://crrev.com/83b7b48f0c6c89d2325ab7fdc96917871acf8708
Cr-Commit-Position: refs/heads/master@{#410117}

[lushnikov, 2016-08-05 07:01:35]

Description was changed from

==========
DevTools: CSSMetadata ref

BUG=none
==========

to

==========
DevTools: do not use CSSMetadata instances for autocompletion

The WI.CSSMetadata should serve a single purpose: hold meta-information about
CSS properties.

However, today WI.CSSMetadata also provides an API for CSS property
autocompletion in
Styles sidebar and Source frame. There's no good reason for that.

BUG=none
==========

[lushnikov, 2016-08-05 07:16:32]

lushnikov@chromium.org changed reviewers:
+ dgozman@chromium.org

[lushnikov, 2016-08-05 07:16:33]

please, take a look

https://codereview.chromium.org/2215253002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js (left):

https://codereview.chromium.org/2215253002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js:35: * @param
{!Array.<!{name: string, longhands: !Array.<string>}|string>} properties
The ambiguity here was coming from the WI.CSSMetadata.keywordsForProperty
method,
which returned a CSSMetadata object.

https://codereview.chromium.org/2215253002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js:135: var
hasSupportedProperties =
WebInspector.CSSMetadata.cssPropertiesMetainfo._values.length > 0;
cssPropertiesMetainfo could be empty iff the SupportedCSSProperties.js was not
served (e.g. in hosted mode).
With the new approach for the hosted mode, this is never a case.

https://codereview.chromium.org/2215253002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js:949: var
firstIndex = this._firstIndexOfPrefix(prefix);
this implementation of startsWith pretends to be fast for no good reason:
maximum length of _values array is <400 elements.

https://codereview.chromium.org/2215253002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js:963: mostUsedOf:
function(properties)
renamed into WI.CSSMetadata.mostUserProperty

https://codereview.chromium.org/2215253002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js:1026: next:
function(str, prefix)
next, previoius, _closest: dead code

[lushnikov, 2016-08-05 07:16:45]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 07:16:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 08:24:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 08:24:55]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-08-05 16:38:21]

lgtm

https://codereview.chromium.org/2215253002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js (right):

https://codereview.chromium.org/2215253002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js:81: if
(propertyName === "line-height")
toLowerCase

https://codereview.chromium.org/2215253002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js:129: var match =
name.match(/(?:-webkit-)(.+)/);
toLowerCase

https://codereview.chromium.org/2215253002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js:965: longhands:
function(shorthand)
Let's follow up with lazy cssMetadata() and all instance methods.

[lushnikov, 2016-08-05 17:12:01]

https://codereview.chromium.org/2215253002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js (right):

https://codereview.chromium.org/2215253002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js:81: if
(propertyName === "line-height")
On 2016/08/05 16:38:21, dgozman wrote:
> toLowerCase

Done.

https://codereview.chromium.org/2215253002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js:129: var match =
name.match(/(?:-webkit-)(.+)/);
On 2016/08/05 16:38:21, dgozman wrote:
> toLowerCase

Done.

https://codereview.chromium.org/2215253002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js:965: longhands:
function(shorthand)
On 2016/08/05 16:38:21, dgozman wrote:
> Let's follow up with lazy cssMetadata() and all instance methods.

Sounds good

[lushnikov, 2016-08-05 17:15:40]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-08-05 17:15:40]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2215253002/#ps100001
(title: "address comments")

[commit-bot: I haz the power, 2016-08-05 17:16:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 18:25:31]

Description was changed from

==========
DevTools: do not use CSSMetadata instances for autocompletion

The WI.CSSMetadata should serve a single purpose: hold meta-information about
CSS properties.

However, today WI.CSSMetadata also provides an API for CSS property
autocompletion in
Styles sidebar and Source frame. There's no good reason for that.

BUG=none
==========

to

==========
DevTools: do not use CSSMetadata instances for autocompletion

The WI.CSSMetadata should serve a single purpose: hold meta-information about
CSS properties.

However, today WI.CSSMetadata also provides an API for CSS property
autocompletion in
Styles sidebar and Source frame. There's no good reason for that.

BUG=none
==========

[commit-bot: I haz the power, 2016-08-05 18:25:32]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-05 18:27:40]

Description was changed from

==========
DevTools: do not use CSSMetadata instances for autocompletion

The WI.CSSMetadata should serve a single purpose: hold meta-information about
CSS properties.

However, today WI.CSSMetadata also provides an API for CSS property
autocompletion in
Styles sidebar and Source frame. There's no good reason for that.

BUG=none
==========

to

==========
DevTools: do not use CSSMetadata instances for autocompletion

The WI.CSSMetadata should serve a single purpose: hold meta-information about
CSS properties.

However, today WI.CSSMetadata also provides an API for CSS property
autocompletion in
Styles sidebar and Source frame. There's no good reason for that.

BUG=none

Committed: https://crrev.com/83b7b48f0c6c89d2325ab7fdc96917871acf8708
Cr-Commit-Position: refs/heads/master@{#410117}
==========

[commit-bot: I haz the power, 2016-08-05 18:27:41]

Patchset 6 (id:??) landed as
https://crrev.com/83b7b48f0c6c89d2325ab7fdc96917871acf8708
Cr-Commit-Position: refs/heads/master@{#410117}