third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js - Issue 2215253002: DevTools: do not use CSSMetadata instances for autocompletion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js

Issue 2215253002: DevTools: do not use CSSMetadata instances for autocompletion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@css-meta-data

Patch Set: address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js b/third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js

index af853de702c031147ba23d87a2af25f9d818feb0..e1170ab1e71fb0cd4f56ecfd2cb439e9d6569e80 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js

@@ -358,7 +358,7 @@ WebInspector.CSSSourceFrame.AutocompleteDelegate.prototype = {

var line = editor.line(prefixRange.startLine);

var tokenContent = line.substring(propertyToken.startColumn, propertyToken.endColumn);

- var keywords = WebInspector.CSSMetadata.keywordsForProperty(tokenContent);

- return keywords.startsWith(prefix);

+ var propertyValues = WebInspector.CSSMetadata.propertyValues(tokenContent);

+ return propertyValues.filter(value => value.startsWith(prefix));

}