Issue 22150003: XMLTreeViewer should be created only in the XML viewer mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22150003: XMLTreeViewer should be created only in the XML viewer mode (Closed)

Created:
7 years, 4 months ago by vivekg_samsung

Modified:
7 years, 4 months ago

Reviewers:
pdr., abarth-chromium, vivekg__

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

XMLTreeViewer should be created only in the XML viewer mode Moving XMLTreeViewer::hasNoStyleInformation to be static inline method in XMLDocumentParser.cpp as it should not be the responsibility of XMLTreeViewer. R=abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155521

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -17 lines)			Patch
M	Source/core/xml/XMLTreeViewer.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/xml/XMLTreeViewer.cpp	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	Source/core/xml/parser/XMLDocumentParser.cpp	View	2 chunks	+16 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/22150003/1

7 years, 4 months ago (2013-08-05 07:43:19 UTC) #3

Message was sent while issue was closed.

Change committed as 155521

Expand Messages | Collapse Messages