Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2214583002:
add use_titlecase for IDS_TRANSLATE_BUBBLE_* (Closed)
|
Created:
4 years, 4 months ago by ftang Modified:
4 years, 4 months ago Reviewers:
groby-ooo-7-16 CC:
chromium-reviews, groby-ooo-7-16 Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionadd use_titlecase for IDS_TRANSLATE_BUBBLE_*
BUG=634196
Committed: https://crrev.com/7d880380df21fffc1eb7c829ae8bea7a6f691963
Cr-Commit-Position: refs/heads/master@{#410192}
Patch Set 1 #
Messages
Total messages: 18 (11 generated)
The CQ bit was checked by ftang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== add use_titlecase for IDS_TRANSLATE_BUBBLE_* BUG=634196 ========== to ========== add use_titlecase for IDS_TRANSLATE_BUBBLE_* BUG=634196 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ftang@chromium.org changed reviewers: + groby@chromium.org
please review
The CQ bit was checked by ftang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by groby@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== add use_titlecase for IDS_TRANSLATE_BUBBLE_* BUG=634196 ========== to ========== add use_titlecase for IDS_TRANSLATE_BUBBLE_* BUG=634196 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== add use_titlecase for IDS_TRANSLATE_BUBBLE_* BUG=634196 ========== to ========== add use_titlecase for IDS_TRANSLATE_BUBBLE_* BUG=634196 Committed: https://crrev.com/7d880380df21fffc1eb7c829ae8bea7a6f691963 Cr-Commit-Position: refs/heads/master@{#410192} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7d880380df21fffc1eb7c829ae8bea7a6f691963 Cr-Commit-Position: refs/heads/master@{#410192} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
