Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2214473003: Don't set MAC address randomization when unsupported (Closed)

Created:
4 years, 4 months ago by stevenjb
Modified:
4 years, 4 months ago
Reviewers:
stevenjb
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Don't set MAC address randomization when unsupported Chrome currently tries to set MAC address randomization on the WiFi device whenever the it detects changes in the device list, but this means it spams shill with calls and floods shill's log with errors if the feature is unsupported. Instead, stop trying to toggle the property when this happens. BUG=630012 R=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2202693005 Cr-Commit-Position: refs/heads/master@{#409388} (cherry picked from commit ad8797fd5b55ee3aff6bf06d2a91633fc294f079) Committed: https://chromium.googlesource.com/chromium/src/+/42f1b3e65bb437d11b965af919eba7194ee615b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -8 lines) Patch
M chromeos/network/network_device_handler_impl.h View 2 chunks +8 lines, -1 line 0 comments Download
M chromeos/network/network_device_handler_impl.cc View 3 chunks +21 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
stevenjb
4 years, 4 months ago (2016-08-04 00:38:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
42f1b3e65bb437d11b965af919eba7194ee615b7.

Powered by Google App Engine
This is Rietveld 408576698