Don't set MAC address randomization when unsupported

Don't set MAC address randomization when unsupported

Chrome currently tries to set MAC address randomization on the
WiFi device whenever the it detects changes in the device list,
but this means it spams shill with calls and floods shill's log
with errors if the feature is unsupported. Instead, stop trying
to toggle the property when this happens.

BUG=630012
R=stevenjb@chromium.org

Committed: https://crrev.com/ad8797fd5b55ee3aff6bf06d2a91633fc294f079
Cr-Commit-Position: refs/heads/master@{#409388}

[Eric Caruso, 2016-08-02 22:33:52]

PTAL, thanks.

[stevenjb, 2016-08-02 22:42:34]

https://codereview.chromium.org/2202693005/diff/1/chromeos/network/network_de...
File chromeos/network/network_device_handler_impl.cc (right):

https://codereview.chromium.org/2202693005/diff/1/chromeos/network/network_de...
chromeos/network/network_device_handler_impl.cc:591: base::Unretained(this)));
We need to use a weak ptr here, otherwise the error callback could get called
during shutdown after this class is deleted.

[Eric Caruso, 2016-08-02 23:03:29]

PTAL, thanks.

[stevenjb, 2016-08-02 23:06:43]

LGTM, thanks for fixing this!

[Eric Caruso, 2016-08-02 23:07:50]

The CQ bit was checked by ejcaruso@chromium.org to run a CQ dry run

[Eric Caruso, 2016-08-02 23:08:10]

The CQ bit was checked by ejcaruso@chromium.org

[commit-bot: I haz the power, 2016-08-02 23:08:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 00:04:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-03 00:07:28]

Description was changed from

==========
Don't set MAC address randomization when unsupported

Chrome currently tries to set MAC address randomization on the
WiFi device whenever the it detects changes in the device list,
but this means it spams shill with calls and floods shill's log
with errors if the feature is unsupported. Instead, stop trying
to toggle the property when this happens.

BUG=630012
R=stevenjb@chromium.org
==========

to

==========
Don't set MAC address randomization when unsupported

Chrome currently tries to set MAC address randomization on the
WiFi device whenever the it detects changes in the device list,
but this means it spams shill with calls and floods shill's log
with errors if the feature is unsupported. Instead, stop trying
to toggle the property when this happens.

BUG=630012
R=stevenjb@chromium.org

Committed: https://crrev.com/ad8797fd5b55ee3aff6bf06d2a91633fc294f079
Cr-Commit-Position: refs/heads/master@{#409388}
==========

[commit-bot: I haz the power, 2016-08-03 00:07:29]

Patchset 2 (id:??) landed as
https://crrev.com/ad8797fd5b55ee3aff6bf06d2a91633fc294f079
Cr-Commit-Position: refs/heads/master@{#409388}