Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2214333003: Restart browser after expected failure. (Closed)

Created:
4 years, 4 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 4 months ago
Reviewers:
Zhenyao Mo
CC:
Corentin Wallez, sugoi1, nednguyen, eyaich1, chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restart browser after expected failure. Occasionally, an expected failure is causing a timeout, which causes the test afterward to fail. Restart the browser in this case for better robustness. BUG=619264 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org Committed: https://crrev.com/b57df21a12bb64a4e685641a7b11472efb07c1a9 Cr-Commit-Position: refs/heads/master@{#409979}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/test/gpu/gpu_tests/gpu_integration_test.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Ken Russell (switch to Gerrit)
FYI. I'm CQ'ing this TBR'd and without unit tests because I'm quite sure it will ...
4 years, 4 months ago (2016-08-05 01:51:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214333003/1
4 years, 4 months ago (2016-08-05 01:51:45 UTC) #6
Ken Russell (switch to Gerrit)
FYI.
4 years, 4 months ago (2016-08-05 02:13:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 03:19:24 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 03:22:25 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b57df21a12bb64a4e685641a7b11472efb07c1a9
Cr-Commit-Position: refs/heads/master@{#409979}

Powered by Google App Engine
This is Rietveld 408576698