Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: content/test/gpu/gpu_tests/gpu_integration_test.py

Issue 2214333003: Restart browser after expected failure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/gpu/gpu_tests/gpu_integration_test.py
diff --git a/content/test/gpu/gpu_tests/gpu_integration_test.py b/content/test/gpu/gpu_tests/gpu_integration_test.py
index e32cc538bb4516d83f78b0e9cc7b8ad50eeaf61a..c05093ff2693252590c5ff5ef133c0f96b31c891 100644
--- a/content/test/gpu/gpu_tests/gpu_integration_test.py
+++ b/content/test/gpu/gpu_tests/gpu_integration_test.py
@@ -69,6 +69,11 @@ class GpuIntegrationTest(
elif expectation == 'fail':
msg = 'Expected exception while running %s' % test_name
exception_formatter.PrintFormattedException(msg=msg)
+ # Even though this is a known failure, the browser might still
+ # be in a bad state; for example, certain kinds of timeouts
+ # will affect the next test. Restart the browser to prevent
+ # these kinds of failures propagating to the next test.
+ self._RestartBrowser('expected test failure')
return
if expectation != 'flaky':
logging.warning(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698