Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2214263003: CustomElements: taking CustomElementReactionStack out of frameHost (Closed)

Created:
4 years, 4 months ago by davaajav
Modified:
4 years, 4 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CustomElements: taking CustomElementReactionStack out of frameHost and creating static object CustomElementReactionStack Taking CustomElementReactionStack out of the frameHost, because having it associated with the frameHost complicates ReactionStack retrieval when an element is moved to a new document. This patch does not change existing behaviours, no need for additional tests. BUG=594918 Committed: https://crrev.com/dda455b659198c46ded45847d250876a81af5d07 Cr-Commit-Position: refs/heads/master@{#410310}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -33 lines) Patch
M third_party/WebKit/Source/core/dom/custom/CEReactionsScope.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CEReactionsScope.cpp View 2 chunks +5 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElement.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementReactionStack.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementReactionStack.cpp View 2 chunks +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.h View 3 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 4 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
davaajav
PTL
4 years, 4 months ago (2016-08-05 08:52:57 UTC) #2
dominicc (has gone to gerrit)
LGTM. I wonder if we can simplify the distinction between the current and backup queue ...
4 years, 4 months ago (2016-08-08 05:21:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214263003/1
4 years, 4 months ago (2016-08-08 06:36:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 06:47:45 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 06:50:01 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dda455b659198c46ded45847d250876a81af5d07
Cr-Commit-Position: refs/heads/master@{#410310}

Powered by Google App Engine
This is Rietveld 408576698