Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2214163003: Minor clean up related to blur mask filters (Closed)

Created:
4 years, 4 months ago by robertphillips
Modified:
4 years, 4 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Minor clean up related to blur mask filters This is the non-substantive portion of: https://codereview.chromium.org/2201133002/ (Implement GPU occluded blur mask filter) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2214163003 Committed: https://skia.googlesource.com/skia/+/9aff85a545703af5880e10726dfb40005ea9934e

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -27 lines) Patch
M gm/occludedrrectblur.cpp View 1 2 chunks +11 lines, -9 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 6 chunks +14 lines, -11 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/SkGpuDevice_drawTexture.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
robertphillips
4 years, 4 months ago (2016-08-04 20:56:52 UTC) #4
robertphillips
ping
4 years, 4 months ago (2016-08-05 12:42:08 UTC) #10
egdaniel
lgtm https://codereview.chromium.org/2214163003/diff/1/gm/occludedrrectblur.cpp File gm/occludedrrectblur.cpp (right): https://codereview.chromium.org/2214163003/diff/1/gm/occludedrrectblur.cpp#newcode152 gm/occludedrrectblur.cpp:152: static const int kWidth = 47; Add a ...
4 years, 4 months ago (2016-08-05 13:37:55 UTC) #11
robertphillips
https://codereview.chromium.org/2214163003/diff/1/gm/occludedrrectblur.cpp File gm/occludedrrectblur.cpp (right): https://codereview.chromium.org/2214163003/diff/1/gm/occludedrrectblur.cpp#newcode152 gm/occludedrrectblur.cpp:152: static const int kWidth = 47; On 2016/08/05 13:37:55, ...
4 years, 4 months ago (2016-08-05 14:18:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214163003/20001
4 years, 4 months ago (2016-08-05 14:50:19 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 14:51:33 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9aff85a545703af5880e10726dfb40005ea9934e

Powered by Google App Engine
This is Rietveld 408576698