Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2214163002: Revert of Expose effective connection type to Cronet (Closed)

Created:
4 years, 4 months ago by tbansal1
Modified:
4 years, 4 months ago
Reviewers:
RyanSturm, Nico, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, pauljensen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Expose effective connection type to Cronet (patchset #6 id:200001 of https://codereview.chromium.org/2146563002/ ) Reason for revert: Speculative revert to see if this fixes failing tests on ClangToTWin(dbg) tester: https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin%28dbg%29%20tester/builds/2913 Original issue's description: > Expose effective connection type to Cronet > > CronetURLContextAdapter registers as an Effective Connection > Type (ECT) Observer. When it receives notifications on > network thread about changes in ECT, it passes them to > Java land where ECT is stored in a guarded variable. > > ECT is computed using transport RTT and downlink bandwidth. > This CL also adds default transport RTT thresholds for > different effective connection types so that NQE can > compute ECT when thresholds have not been specified using > field trial params (as is the case for Cronet). > > BUG=625305 > > Committed: https://crrev.com/16cad789693aa8032dec86a8585e0dcec5f6124e > Cr-Commit-Position: refs/heads/master@{#409624} TBR=ryansturm@chromium.org,xunjieli@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=625305 Committed: https://crrev.com/aa64633ecf68180fe381a0b5c31b874d4aab7ee8 Cr-Commit-Position: refs/heads/master@{#409873}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
tbansal1
Created Revert of Expose effective connection type to Cronet
4 years, 4 months ago (2016-08-04 19:45:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214163002/1
4 years, 4 months ago (2016-08-04 19:45:42 UTC) #3
xunjieli
lgtm. Tarun: when relanding your CL, could you rebase it on top of https://codereview.chromium.org/2210633002/ and ...
4 years, 4 months ago (2016-08-04 19:47:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 19:47:52 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 19:51:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa64633ecf68180fe381a0b5c31b874d4aab7ee8
Cr-Commit-Position: refs/heads/master@{#409873}

Powered by Google App Engine
This is Rietveld 408576698