Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

Issue 2214163002: Revert of Expose effective connection type to Cronet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java
diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java
index 57daa09bd363ac5ea0541dddb86aed498f8ab1c3..47d4345be6badb8147a47238315ce1610aed2871 100644
--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java
+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java
@@ -20,7 +20,6 @@
import org.chromium.base.annotations.UsedByReflection;
import org.chromium.net.BidirectionalStream;
import org.chromium.net.CronetEngine;
-import org.chromium.net.EffectiveConnectionType;
import org.chromium.net.NetworkQualityRttListener;
import org.chromium.net.NetworkQualityThroughputListener;
import org.chromium.net.RequestFinishedInfo;
@@ -77,14 +76,6 @@
* on any thread.
*/
private final Object mFinishedListenerLock = new Object();
-
- /**
- * Current effective connection type as computed by the network quality
- * estimator.
- */
- @GuardedBy("mNetworkQualityLock")
- private int mEffectiveConnectionType =
- EffectiveConnectionType.EFFECTIVE_CONNECTION_TYPE_UNKNOWN;
@GuardedBy("mNetworkQualityLock")
private final ObserverList<NetworkQualityRttListener> mRttListenerList =
@@ -269,17 +260,6 @@
return nativeGetHistogramDeltas();
}
- @Override
- public int getEffectiveConnectionType() {
- if (!mNetworkQualityEstimatorEnabled) {
- throw new IllegalStateException("Network quality estimator must be enabled");
- }
- synchronized (mNetworkQualityLock) {
- checkHaveAdapter();
- return mEffectiveConnectionType;
- }
- }
-
@VisibleForTesting
@Override
public void configureNetworkQualityEstimatorForTesting(
@@ -453,17 +433,6 @@
}
Thread.currentThread().setName("ChromiumNet");
Process.setThreadPriority(Process.THREAD_PRIORITY_BACKGROUND);
- }
-
- @SuppressWarnings("unused")
- @CalledByNative
- private void onEffectiveConnectionTypeChanged(int effectiveConnectionType) {
- synchronized (mNetworkQualityLock) {
- // Convert the enum returned by the network quality estimator to an enum of type
- // EffectiveConnectionType.
- mEffectiveConnectionType =
- EffectiveConnectionType.getEffectiveConnectionType(effectiveConnectionType);
- }
}
@SuppressWarnings("unused")

Powered by Google App Engine
This is Rietveld 408576698