Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2213973002: Update skimage VERSION: attempt 2 (Closed)

Created:
4 years, 4 months ago by msarett
Modified:
4 years, 4 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M infra/bots/assets/skimage/VERSION View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
msarett
Let's give this another shot...
4 years, 4 months ago (2016-08-04 13:30:57 UTC) #5
borenet
LGTM. You could add a Win.*Test trybot to be sure, but if you manually copied ...
4 years, 4 months ago (2016-08-04 13:32:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2213973002/1
4 years, 4 months ago (2016-08-04 14:28:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/d6dec3f4a1365d34e147234acf3c4a3629146457
4 years, 4 months ago (2016-08-04 14:29:13 UTC) #12
msarett
4 years, 4 months ago (2016-08-04 14:46:36 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2216523003/ by msarett@google.com.

The reason for reverting is: Think this is going to break Windows again..

Powered by Google App Engine
This is Rietveld 408576698