base/threading/simple_thread_unittest.cc - Issue 2213933003: Change EXPECT/ASSERT_DCHECK_DEATH macro to not expose the |regex| parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/threading/simple_thread_unittest.cc

Issue 2213933003: Change EXPECT/ASSERT_DCHECK_DEATH macro to not expose the |regex| parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b2b0_simplethreadJoinable

Patch Set: Disabling a death test which crashed instead of DCHECKing : http://crbug.com/634552 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/threading/simple_thread_unittest.cc

diff --git a/base/threading/simple_thread_unittest.cc b/base/threading/simple_thread_unittest.cc

index 6c64a04f2e8bbb2e4a036e7bdd2e871fe782f9b2..26e3a907bc7b5faed77525e59f0a758fabc0472f 100644

--- a/base/threading/simple_thread_unittest.cc

+++ b/base/threading/simple_thread_unittest.cc

@@ -153,7 +153,7 @@ TEST(SimpleThreadTest, JoinNonJoinableThreadDeath) {

DelegateSimpleThread thread(&runner, "noop_runner", options);

thread.Start();

- EXPECT_DCHECK_DEATH(thread.Join(), "");

+ EXPECT_DCHECK_DEATH(thread.Join());

}

TEST(SimpleThreadTest, DeleteNonJoinableWithoutJoinIsSafe) {

« no previous file with comments | « base/threading/non_thread_safe_unittest.cc ('k') | base/threading/thread_restrictions.cc » ('j') | no next file with comments »