base/threading/non_thread_safe_unittest.cc - Issue 2213933003: Change EXPECT/ASSERT_DCHECK_DEATH macro to not expose the |regex| parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/threading/non_thread_safe_unittest.cc

Issue 2213933003: Change EXPECT/ASSERT_DCHECK_DEATH macro to not expose the |regex| parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b2b0_simplethreadJoinable

Patch Set: Disabling a death test which crashed instead of DCHECKing : http://crbug.com/634552 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/threading/non_thread_safe_unittest.cc

diff --git a/base/threading/non_thread_safe_unittest.cc b/base/threading/non_thread_safe_unittest.cc

index 95f699d0ca236d081374e91739a9be492f219326..7776228f2f29a99c509c11db0ee496b0f69c1fd5 100644

--- a/base/threading/non_thread_safe_unittest.cc

+++ b/base/threading/non_thread_safe_unittest.cc

@@ -113,8 +113,7 @@ void NonThreadSafeClass::MethodOnDifferentThreadImpl() {

#if DCHECK_IS_ON()

TEST(NonThreadSafeDeathTest, MethodNotAllowedOnDifferentThreadInDebug) {

- ASSERT_DCHECK_DEATH({ NonThreadSafeClass::MethodOnDifferentThreadImpl(); },

- "");

+ ASSERT_DCHECK_DEATH({ NonThreadSafeClass::MethodOnDifferentThreadImpl(); });

}

#else

TEST(NonThreadSafeTest, MethodAllowedOnDifferentThreadInRelease) {

@@ -138,7 +137,7 @@ void NonThreadSafeClass::DestructorOnDifferentThreadImpl() {

#if DCHECK_IS_ON()

TEST(NonThreadSafeDeathTest, DestructorNotAllowedOnDifferentThreadInDebug) {

ASSERT_DCHECK_DEATH(

- { NonThreadSafeClass::DestructorOnDifferentThreadImpl(); }, "");

+ { NonThreadSafeClass::DestructorOnDifferentThreadImpl(); });

}

#else

TEST(NonThreadSafeTest, DestructorAllowedOnDifferentThreadInRelease) {

« no previous file with comments | « base/test/gtest_util.h ('k') | base/threading/simple_thread_unittest.cc » ('j') | no next file with comments »