base/numerics/safe_numerics_unittest.cc - Issue 2213933003: Change EXPECT/ASSERT_DCHECK_DEATH macro to not expose the |regex| parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/numerics/safe_numerics_unittest.cc

Issue 2213933003: Change EXPECT/ASSERT_DCHECK_DEATH macro to not expose the |regex| parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b2b0_simplethreadJoinable

Patch Set: Disabling a death test which crashed instead of DCHECKing : http://crbug.com/634552 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/numerics/safe_numerics_unittest.cc

diff --git a/base/numerics/safe_numerics_unittest.cc b/base/numerics/safe_numerics_unittest.cc

index b602e65a86615897067f02c7015ca88052c7e52f..28ed5666d426e95594fbd98a944f654ca038959e 100644

--- a/base/numerics/safe_numerics_unittest.cc

+++ b/base/numerics/safe_numerics_unittest.cc

@@ -656,8 +656,7 @@ TEST(SafeNumerics, SaturatedCastChecks) {

std::numeric_limits<float>::infinity();

EXPECT_TRUE(std::isnan(not_a_number));

EXPECT_DCHECK_DEATH(

- (saturated_cast<int, base::SaturatedCastNaNBehaviorCheck>(not_a_number)),

- "");

+ (saturated_cast<int, base::SaturatedCastNaNBehaviorCheck>(not_a_number)));

}

TEST(SafeNumerics, IsValueInRangeForNumericType) {

« no previous file with comments | « base/metrics/sample_vector_unittest.cc ('k') | base/synchronization/atomic_flag_unittest.cc » ('j') | no next file with comments »