base/synchronization/atomic_flag_unittest.cc - Issue 2213933003: Change EXPECT/ASSERT_DCHECK_DEATH macro to not expose the |regex| parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/synchronization/atomic_flag_unittest.cc

Issue 2213933003: Change EXPECT/ASSERT_DCHECK_DEATH macro to not expose the |regex| parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b2b0_simplethreadJoinable

Patch Set: Disabling a death test which crashed instead of DCHECKing : http://crbug.com/634552 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/synchronization/atomic_flag_unittest.cc

diff --git a/base/synchronization/atomic_flag_unittest.cc b/base/synchronization/atomic_flag_unittest.cc

index a08e321f7a317b5b6aad8842168a781504cbec95..a3aa3341a0d1ef500a414335e41e97dd7f2470d7 100644

--- a/base/synchronization/atomic_flag_unittest.cc

+++ b/base/synchronization/atomic_flag_unittest.cc

@@ -20,7 +20,7 @@ namespace {

void ExpectSetFlagDeath(AtomicFlag* flag) {

ASSERT_TRUE(flag);

- EXPECT_DCHECK_DEATH(flag->Set(), "");

+ EXPECT_DCHECK_DEATH(flag->Set());

}

// Busy waits (to explicitly avoid using synchronization constructs that would

« no previous file with comments | « base/numerics/safe_numerics_unittest.cc ('k') | base/task_scheduler/priority_queue_unittest.cc » ('j') | no next file with comments »