Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1097)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2213673002: Delete dart_backend from compiler. (Closed)

Created:
4 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 4 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org, Johnni Winther, Bill Hesse
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -10494 lines) Patch
M create_sdk.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +1 line, -8 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 9 chunks +12 lines, -31 lines 0 comments Download
D pkg/compiler/lib/src/dart_backend/backend.dart View 1 chunk +0 lines, -546 lines 0 comments Download
D pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart View 1 chunk +0 lines, -93 lines 0 comments Download
D pkg/compiler/lib/src/dart_backend/backend_ast_nodes.dart View 1 chunk +0 lines, -1556 lines 0 comments Download
D pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart View 1 chunk +0 lines, -1353 lines 0 comments Download
D pkg/compiler/lib/src/dart_backend/dart_backend.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D pkg/compiler/lib/src/dart_backend/outputter.dart View 1 chunk +0 lines, -576 lines 0 comments Download
D pkg/compiler/lib/src/dart_backend/placeholder_collector.dart View 1 chunk +0 lines, -724 lines 0 comments Download
D pkg/compiler/lib/src/dart_backend/renamer.dart View 1 chunk +0 lines, -372 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 1 chunk +4 lines, -1 line 0 comments Download
D pkg/compiler/lib/src/mirror_renamer/mirror_renamer.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D pkg/compiler/lib/src/mirror_renamer/renamer.dart View 1 chunk +0 lines, -118 lines 0 comments Download
M pkg/compiler/lib/src/options.dart View 17 chunks +3 lines, -27 lines 0 comments Download
M samples/samples.status View 1 chunk +0 lines, -4 lines 0 comments Download
D sdk/lib/_internal/js_runtime/lib/mirror_helper.dart View 1 chunk +0 lines, -25 lines 0 comments Download
M sdk/lib/_internal/sdk_library_metadata/lib/libraries.dart View 1 chunk +0 lines, -8 lines 0 comments Download
D sdk/lib/dart2dart.platform View 1 chunk +0 lines, -49 lines 0 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 2 chunks +0 lines, -7 lines 0 comments Download
D tests/compiler/dart2js/backend_dart/dart_backend_test.dart View 1 chunk +0 lines, -1119 lines 0 comments Download
D tests/compiler/dart2js/backend_dart/dart_printer_test.dart View 1 chunk +0 lines, -990 lines 0 comments Download
D tests/compiler/dart2js/backend_dart/end2end_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D tests/compiler/dart2js/backend_dart/opt_constprop_test.dart View 1 chunk +0 lines, -528 lines 0 comments Download
D tests/compiler/dart2js/backend_dart/opt_cyclic_redundant_phi_test.dart View 1 chunk +0 lines, -97 lines 0 comments Download
D tests/compiler/dart2js/backend_dart/opt_redundant_phi_test.dart View 1 chunk +0 lines, -309 lines 0 comments Download
D tests/compiler/dart2js/backend_dart/opt_shrinking_test.dart View 1 chunk +0 lines, -331 lines 0 comments Download
D tests/compiler/dart2js/backend_dart/sexpr2_test.dart View 1 chunk +0 lines, -62 lines 0 comments Download
D tests/compiler/dart2js/backend_dart/sexpr_test.dart View 1 chunk +0 lines, -177 lines 0 comments Download
D tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart View 1 chunk +0 lines, -885 lines 0 comments Download
D tests/compiler/dart2js/backend_dart/test_helper.dart View 1 chunk +0 lines, -46 lines 0 comments Download
M tests/compiler/dart2js/generate_code_with_compile_time_errors_test.dart View 3 chunks +2 lines, -30 lines 0 comments Download
M tests/compiler/dart2js/message_kind_helper.dart View 2 chunks +1 line, -12 lines 0 comments Download
D tests/compiler/dart2js/mirror_helper_rename_test.dart View 1 chunk +0 lines, -108 lines 0 comments Download
D tests/compiler/dart2js/mirror_helper_test.dart View 1 chunk +0 lines, -94 lines 0 comments Download
D tests/compiler/dart2js/mirror_helper_unique_minification_test.dart View 1 chunk +0 lines, -89 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/platform_consistency_test.dart View 2 chunks +0 lines, -5 lines 0 comments Download
M tests/language/dangling_else_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/create_sdk.py View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Siggi Cherem (dart-lang)
4 years, 4 months ago (2016-08-04 22:17:32 UTC) #4
Siggi Cherem (dart-lang)
4 years, 4 months ago (2016-08-04 22:18:20 UTC) #5
sra1
LGTM. We might still want an output language for ES5 vs ES6. I assume test ...
4 years, 4 months ago (2016-08-04 22:44:50 UTC) #6
Siggi Cherem (dart-lang)
+Bill I wasn't able to find anything in our testing scripts mentioning dart2dart. Is it ...
4 years, 4 months ago (2016-08-04 22:51:16 UTC) #7
Siggi Cherem (dart-lang)
4 years, 4 months ago (2016-08-04 22:57:11 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:40001) manually as
0eee4027a64367efd1c697ff9b637b0b1e9810d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698