Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: tests/compiler/dart2js/message_kind_helper.dart

Issue 2213673002: Delete dart_backend from compiler. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/message_kind_helper.dart
diff --git a/tests/compiler/dart2js/message_kind_helper.dart b/tests/compiler/dart2js/message_kind_helper.dart
index 34e7efeb33f7b83ba4ea854ff23c18789ae12edd..31094e4ac55bc3d93b7a529d4c500040c144dcb7 100644
--- a/tests/compiler/dart2js/message_kind_helper.dart
+++ b/tests/compiler/dart2js/message_kind_helper.dart
@@ -10,8 +10,6 @@ import 'dart:async';
import 'package:compiler/src/commandline_options.dart';
import 'package:compiler/src/compiler.dart' show
Compiler;
-import 'package:compiler/src/dart_backend/dart_backend.dart' show
- DartBackend;
import 'package:compiler/src/diagnostics/messages.dart' show
MessageKind,
MessageTemplate;
@@ -71,21 +69,12 @@ Future<Compiler> check(MessageTemplate template, Compiler cachedCompiler) {
}
DiagnosticCollector collector = new DiagnosticCollector();
- bool oldBackendIsDart;
- if (cachedCompiler != null) {
- oldBackendIsDart = cachedCompiler.backend is DartBackend;
- }
- bool newBackendIsDart = template.options.contains('--output-type=dart');
-
Compiler compiler = compilerFor(
memorySourceFiles: example,
diagnosticHandler: collector,
options: [Flags.analyzeOnly,
Flags.enableExperimentalMirrors]..addAll(template.options),
- cachedCompiler:
- // TODO(johnniwinther): Remove this restriction when constant
- // values can be computed directly from the expressions.
- oldBackendIsDart == newBackendIsDart ? cachedCompiler : null);
+ cachedCompiler: cachedCompiler);
return compiler.run(Uri.parse('memory:main.dart')).then((_) {
Iterable<CollectedMessage> messages = collector.filterMessagesByKinds(

Powered by Google App Engine
This is Rietveld 408576698