Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2213223004: Revert of Add a fast-path for independent inherited properties (Closed)

Created:
4 years, 4 months ago by rune
Modified:
4 years, 4 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@computedstyle_cleanup_rename_final_member_fields
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a fast-path for independent inherited properties (patchset #13 id:240001 of https://codereview.chromium.org/2117143003/ ) Reason for revert: Caused issues 634254 and 633859. Original issue's description: > Add a fast-path for independent inherited properties > > Add a fast-path for inherited properties which do not depend on and do > not affect any other properties on ComputedStyle. When these properties > are modified in a parent element, set them directly on ComputedStyle and > skip doing a full recalc for elements only affected by this change. > > Also implemented two of these properties: visibility and pointer-events, > storing an extra 2 bits per ComputedStyle. This increases the size of > ComputedStyle by 1 byte on Windows and some Android builds (due to > aligned fields), which increases the memory usage for a standard page > with ~1000 elements by up to 1kb (although potentially up to 4/8kb on > 32/64 bit builds due to packing, although this depends on the allocator > implementation details) but realistically less since style sharing only > creates one ComputedStyle object for each unique style. > > Benchmarks show a speed increase of up to 2x for setting these > properties on the root element of a typical web page (Facebook, Twitter, > Pinterest, Amazon, Wikipedia) and letting the change propagate directly > onto the child ComputedStyle objects, rather than doing a full style > recalc. > > Initial Benchmarks: > https://docs.google.com/spreadsheets/d/1mUuJEs8cPWyNTR7tQw27oxq6fDTvWiAwgatf_g--B4w/edit#gid=1597242813 > > Follow-up Benchmarks: > https://docs.google.com/spreadsheets/d/1mUuJEs8cPWyNTR7tQw27oxq6fDTvWiAwgatf_g--B4w/edit#gid=918856082 > > BUG=622138 > > Committed: https://crrev.com/f24dba9f04dd093aac4298378c671ecd44d0fe97 > Cr-Commit-Position: refs/heads/master@{#409143} TBR=esprehn@chromium.org,meade@chromium.org,timloh@chromium.org,sashab@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=622138 Committed: https://crrev.com/bf9f7aeb812949577490b55e40dd36c8eca7b8f9 Cr-Commit-Position: refs/heads/master@{#410030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -401 lines) Patch
D third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path-multiple-properties.html View 1 chunk +0 lines, -95 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/invalidation/non-independent-inheritance-identical-computed-styles.html View 1 chunk +0 lines, -74 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/css_properties.py View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/make_style_builder.py View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 4 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 3 chunks +2 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolverStats.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolverStats.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 3 chunks +7 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 10 chunks +6 lines, -54 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 5 chunks +3 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
rune
Created Revert of Add a fast-path for independent inherited properties
4 years, 4 months ago (2016-08-05 10:05:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2213223004/1
4 years, 4 months ago (2016-08-05 10:05:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 11:22:28 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 11:23:48 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf9f7aeb812949577490b55e40dd36c8eca7b8f9
Cr-Commit-Position: refs/heads/master@{#410030}

Powered by Google App Engine
This is Rietveld 408576698