third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl - Issue 2213223004: Revert of Add a fast-path for independent inherited properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

Issue 2213223004: Revert of Add a fast-path for independent inherited properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@computedstyle_cleanup_rename_final_member_fields

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/make_style_builder.py ('k') | third_party/WebKit/Source/core/css/CSSProperties.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

index 8e627b225fbb18c3407bbdfc487ad0c1e9d18ba8..241ed5cbcfedaca0cf9d17382d629555c865440e 100644

--- a/third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

@@ -43,9 +43,6 @@

{{set_value(property)}}(toCSSPrimitiveValue(value).convertTo<{{property.type_name}}>());

{%- endif %}

{% endmacro %}

-{% macro set_is_inherited(property) %}

-state.style()->{{property.is_inherited_setter}}

-{% endmacro %}

namespace blink {

@@ -61,9 +58,6 @@

{% else %}

{{set_value(property)}}(ComputedStyle::{{property.initial}}());

{% endif %}

- {% if property.independent %}

- {{set_is_inherited(property)}}(true);

- {% endif %}

}

{% endif %}

@@ -77,9 +71,6 @@

{% else %}

{{set_value(property)}}(state.parentStyle()->{{property.getter}}());

{% endif %}

- {% if property.independent %}

- {{set_is_inherited(property)}}(false);

- {% endif %}

}

{% endif %}

@@ -87,9 +78,6 @@

{

- {% if property.independent %}

- {{set_is_inherited(property)}}(false);

- {% endif %}

}

{% endif %}