Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2212873002: Remove SingleHostResolver completely. (Closed)

Created:
4 years, 4 months ago by maksims (do not use this acc)
Modified:
4 years, 4 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@SingleRemoveCallers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SingleHostResolver completely. There is no need in SingleHostResolver after HostResolver::Request was implemented and HostResolver::Resolve() started to take unique_ptr instead of a raw pointer. First part - https://codereview.chromium.org/2214693002/ THIS CL WILL BE COMMITTED ONCE FIRST PART IS UPSTREAMED BUG=630301 Committed: https://crrev.com/b3b148c2f65ecff150684f8fb470b46d8fdc336c Cr-Commit-Position: refs/heads/master@{#412172}

Patch Set 1 #

Patch Set 2 : rebased to fix remote refs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -292 lines) Patch
D net/dns/single_request_host_resolver.h View 1 chunk +0 lines, -64 lines 0 comments Download
D net/dns/single_request_host_resolver.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D net/dns/single_request_host_resolver_unittest.cc View 1 chunk +0 lines, -150 lines 0 comments Download
M net/net.gypi View 1 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
maksims (do not use this acc)
ptal
4 years, 4 months ago (2016-08-09 09:48:34 UTC) #3
mmenke
LGTM, once the prerequisite CL has landed.
4 years, 4 months ago (2016-08-10 20:46:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2212873002/1
4 years, 4 months ago (2016-08-16 04:52:11 UTC) #9
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 4 months ago (2016-08-16 04:52:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2212873002/20001
4 years, 4 months ago (2016-08-16 05:03:15 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-16 05:43:39 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 05:46:51 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b3b148c2f65ecff150684f8fb470b46d8fdc336c
Cr-Commit-Position: refs/heads/master@{#412172}

Powered by Google App Engine
This is Rietveld 408576698