Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: net/dns/single_request_host_resolver.cc

Issue 2212873002: Remove SingleHostResolver completely. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SingleRemoveCallers
Patch Set: rebased to fix remote refs Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "net/dns/single_request_host_resolver.h"
6
7 #include "base/bind.h"
8 #include "base/bind_helpers.h"
9 #include "base/compiler_specific.h"
10 #include "base/logging.h"
11 #include "net/base/net_errors.h"
12
13 namespace net {
14
15 SingleRequestHostResolver::SingleRequestHostResolver(HostResolver* resolver)
16 : resolver_(resolver),
17 callback_(
18 base::Bind(&SingleRequestHostResolver::OnResolveCompletion,
19 base::Unretained(this))) {
20 DCHECK(resolver_ != nullptr);
21 }
22
23 SingleRequestHostResolver::~SingleRequestHostResolver() {
24 Cancel();
25 }
26
27 int SingleRequestHostResolver::Resolve(const HostResolver::RequestInfo& info,
28 RequestPriority priority,
29 AddressList* addresses,
30 const CompletionCallback& callback,
31 const BoundNetLog& net_log) {
32 DCHECK(addresses);
33 DCHECK_EQ(false, callback.is_null());
34 DCHECK(cur_request_callback_.is_null()) << "resolver already in use";
35
36 std::unique_ptr<HostResolver::Request> request;
37
38 // We need to be notified of completion before |callback| is called, so that
39 // we can clear out |cur_request_*|.
40 CompletionCallback transient_callback =
41 callback.is_null() ? CompletionCallback() : callback_;
42
43 int rv = resolver_->Resolve(
44 info, priority, addresses, transient_callback, &request, net_log);
45
46 if (rv == ERR_IO_PENDING) {
47 DCHECK_EQ(false, callback.is_null());
48 // Cleared in OnResolveCompletion().
49 cur_request_ = std::move(request);
50 cur_request_callback_ = callback;
51 }
52
53 return rv;
54 }
55
56 void SingleRequestHostResolver::Cancel() {
57 cur_request_.reset();
58 cur_request_callback_.Reset();
59 }
60
61 void SingleRequestHostResolver::OnResolveCompletion(int result) {
62 DCHECK(cur_request_);
63 DCHECK_EQ(false, cur_request_callback_.is_null());
64
65 CompletionCallback callback = cur_request_callback_;
66
67 // Clear the outstanding request information.
68 cur_request_.reset();
69 cur_request_callback_.Reset();
70
71 // Call the user's original callback.
72 callback.Run(result);
73 }
74
75 } // namespace net
OLDNEW
« no previous file with comments | « net/dns/single_request_host_resolver.h ('k') | net/dns/single_request_host_resolver_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698