Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2212343002: Revert of [Interpreter] Collect type feedback for 'new' in the bytecode handler (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, rmcilroy, v8-ppc-ports_googlegroups.com, oth, Michael Starzinger
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Interpreter] Collect type feedback for 'new' in the bytecode handler (patchset #6 id:100001 of https://codereview.chromium.org/2190293003/ ) Reason for revert: [Sheriff] Fails on nosnap debug: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/8403 Original issue's description: > [Interpreter] Collect type feedback for 'new' in the bytecode handler > > Collect type feedback in the bytecode handler for 'new' bytecode. The > earlier cl (https://codereview.chromium.org/2153433002/) was reverted > because that implementation did not collect allocation site feedback. > This regressed delta blue by an order of magnitude. This implementation > includes collection of allocation site feedback. > > BUG=v8:4280, v8:4780 > LOG=N > > Committed: https://crrev.com/9d5e6129c4c7f9cbfe81a5fad2a470f219fe137c > Cr-Commit-Position: refs/heads/master@{#38364} TBR=bmeurer@chromium.org,rmcilroy@chromium.org,balazs.kilvady@imgtec.com,mythria@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280, v8:4780 Committed: https://crrev.com/dea16c9a42d54057efac159d6bced8e26e2c4a94 Cr-Commit-Position: refs/heads/master@{#38368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -552 lines) Patch
M src/arm/interface-descriptors-arm.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/builtins/arm/builtins-arm.cc View 2 chunks +8 lines, -26 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 3 chunks +7 lines, -24 lines 0 comments Download
M src/builtins/builtins.h View 3 chunks +1 line, -6 lines 0 comments Download
M src/builtins/builtins-interpreter.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 3 chunks +32 lines, -109 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 2 chunks +9 lines, -24 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 2 chunks +9 lines, -24 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 5 chunks +17 lines, -39 lines 0 comments Download
M src/code-factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/code-factory.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 3 chunks +3 lines, -10 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/interpreter/interpreter-assembler.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 2 chunks +6 lines, -197 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/cctest.status View 4 chunks +16 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallNew.golden View 4 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 3 chunks +6 lines, -11 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [Interpreter] Collect type feedback for 'new' in the bytecode handler
4 years, 4 months ago (2016-08-05 10:32:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2212343002/1
4 years, 4 months ago (2016-08-05 10:33:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 10:33:17 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 10:36:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dea16c9a42d54057efac159d6bced8e26e2c4a94
Cr-Commit-Position: refs/heads/master@{#38368}

Powered by Google App Engine
This is Rietveld 408576698