Implement app launch changes for app runtime extension proposal.

extensions/common/api/app_runtime.idl

Index: extensions/common/api/app_runtime.idl
diff --git a/extensions/common/api/app_runtime.idl b/extensions/common/api/app_runtime.idl
index 4a848f808ec6bcc39b5faec38c43eab0a9d06726..fdb3566db649f6239e420587a7445ec8b4873ca8 100644
--- a/extensions/common/api/app_runtime.idl
+++ b/extensions/common/api/app_runtime.idl
@@ -35,7 +35,22 @@ namespace app.runtime {
     kiosk,
     chrome_internal,
     test,
-    installed_notification
+    installed_notification,
+    action

[Daniel Erat, 2016/08/05 23:36:46]

i left a high-level comment on the api proposal about this; it feels strange to
me for this to be a LaunchSource rather than an additional field in app.runtime
describing the action that the app should perform.

[jdufault, 2016/08/10 22:01:17]

I've removed the launch source for the time being, but depending on rdcronin@'s
thoughts I may bring it back.

+  };
+
+  // Enumeration of the different ways notes are launched/created. Possible
+  // other names include 'Action' or 'Workflow'. The idea is to encapsulate all

[Daniel Erat, 2016/08/05 23:36:46]

i don't understand the "possible other names" sentence. where will those other
names be used?

[jdufault, 2016/08/10 22:01:17]

Blah, this is an accidental change that shouldn't be here. I'll tidy up the
comments.

+  // launch sources where the user wants to complete some specific action /
+  // user-flow.
+  enum ActionType {
+    new_note
+  };
+
+  // Specifies the specific <code>ActionType</code> the app was launched with.

[Daniel Erat, 2016/08/05 23:36:45]

nit: delete "specific" since "specifies" is already pretty specific :-)

[jdufault, 2016/08/10 22:01:17]

Done.

+  // This also contains any action-type specific data.

[Daniel Erat, 2016/08/05 23:36:46]

nit: i'd delete this until such data has actually been added to it

[jdufault, 2016/08/10 22:01:17]

Done.

+  dictionary ActionData {
+    ActionType action_type;
   };
 
   // Optional data for the launch. Either <code>items</code>, or
@@ -71,6 +86,11 @@ namespace app.runtime {
 
     // Where the app is launched from.
     LaunchSource? source;
+
+    // Contains data that specifies what type of action this app was launched
+    // with. This also contains any action specific data. This is only relevant

[Daniel Erat, 2016/08/05 23:36:45]

nit: the second sentence seems extraneous since it's currently already
documented above the ActionData dictionary

[jdufault, 2016/08/10 22:01:17]

Done.

+    // if the <code>LaunchSource</code> is equal to <code>action</code>.
+    ActionData? action_data;
   };
 
   // This object specifies details and operations to perform on the embedding