Implement app launch changes for app runtime extension proposal.

extensions/common/api/app_runtime.idl

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Use the <code>chrome.app.runtime</code> API to manage the app lifecycle.
 // The app runtime manages app installation, controls the event page, and can
 // shut down the app at anytime.
 namespace app.runtime {
 
   [inline_doc] dictionary LaunchItem {
@@ skipping 17 matching lines @@
     system_tray,
     about_page,
     keyboard,
     extensions_page,
     management_api,
     ephemeral_app,
     background,
     kiosk,
     chrome_internal,
     test,
-    installed_notification
+    installed_notification,
+    action

[Daniel Erat, 2016/08/05 23:36:46]

i left a high-level comment on the api proposal about this; it feels strange to
me for this to be a LaunchSource rather than an additional field in app.runtime
describing the action that the app should perform.

[jdufault, 2016/08/10 22:01:17]

I've removed the launch source for the time being, but depending on rdcronin@'s
thoughts I may bring it back.

+  };
+
+  // Enumeration of the different ways notes are launched/created. Possible
+  // other names include 'Action' or 'Workflow'. The idea is to encapsulate all

[Daniel Erat, 2016/08/05 23:36:46]

i don't understand the "possible other names" sentence. where will those other
names be used?

[jdufault, 2016/08/10 22:01:17]

Blah, this is an accidental change that shouldn't be here. I'll tidy up the
comments.

+  // launch sources where the user wants to complete some specific action /
+  // user-flow.
+  enum ActionType {
+    new_note
+  };
+
+  // Specifies the specific <code>ActionType</code> the app was launched with.

[Daniel Erat, 2016/08/05 23:36:45]

nit: delete "specific" since "specifies" is already pretty specific :-)

[jdufault, 2016/08/10 22:01:17]

Done.

+  // This also contains any action-type specific data.

[Daniel Erat, 2016/08/05 23:36:46]

nit: i'd delete this until such data has actually been added to it

[jdufault, 2016/08/10 22:01:17]

Done.

+  dictionary ActionData {
+    ActionType action_type;
   };
 
   // Optional data for the launch. Either <code>items</code>, or
   // the pair (<code>url, referrerUrl</code>) can be present for any given
   // launch.
   [inline_doc] dictionary LaunchData {
     // The ID of the file or URL handler that the app is being invoked with.
     // Handler IDs are the top-level keys in the <code>file_handlers</code>
     // and/or <code>url_handlers</code> dictionaries in the manifest.
     DOMString? id;
@@ skipping 15 matching lines @@
     // kiosk session</a>.
     boolean? isKioskSession;
 
     // Whether the app is being launched in a <a
     // href="https://support.google.com/chrome/a/answer/3017014">Chrome OS
     // public session</a>.
     boolean? isPublicSession;
 
     // Where the app is launched from.
     LaunchSource? source;
+
+    // Contains data that specifies what type of action this app was launched
+    // with. This also contains any action specific data. This is only relevant

[Daniel Erat, 2016/08/05 23:36:45]

nit: the second sentence seems extraneous since it's currently already
documented above the ActionData dictionary

[jdufault, 2016/08/10 22:01:17]

Done.

+    // if the <code>LaunchSource</code> is equal to <code>action</code>.
+    ActionData? action_data;
   };
 
   // This object specifies details and operations to perform on the embedding
   // request. The app to be embedded can make a decision on whether or not to
   // allow the embedding and what to embed based on the embedder making the
   // request.
   dictionary EmbedRequest {
     DOMString embedderId;
 
     // Optional developer specified data that the app to be embedded can use
@@ skipping 19 matching lines @@
 
     // Fired at Chrome startup to apps that were running when Chrome last shut
     // down, or when apps have been requested to restart from their previous
     // state for other reasons (e.g. when the user revokes access to an app's
     // retained files the runtime will restart the app). In these situations if
     // apps do not have an <code>onRestarted</code> handler they will be sent
     // an <code>onLaunched </code> event instead.
     static void onRestarted();
   };
 };