Use LayoutObject::selectionState() to check whether selection contains node or not

Use LayoutObject::selectionState() to check whether selection contains node or not

This patch changes |FrameSelection::respondToNodeModification()| to check
whether node to be removed in selection or not by using value of
|LayoutObject::selectionState()| instead of using |Range::intersectsNode()| to
make node removal faster.

Execution time of attached performance test on my local PC:
Before: 3.80ms
After: 2.92ms

"fast/repaint/selection-after-remove.html" needs rebaseline since this patch
reduce invalidate elements, e.g. HTML and BODY elements aren't invalidated.

BUG=259874, 505335, 632333
TEST=PerformanceTests/DOM/remove_child_with_selection.html

Committed: https://crrev.com/3316ab0c51851da3f4ad14a7a273c21b542ba8f4
Cr-Commit-Position: refs/heads/master@{#410308}

[yosin_UTC9, 2016-08-05 06:43:38]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 06:43:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-08-05 06:50:42]

Description was changed from

==========
2016-08-05T15:40:43

BUG=
==========

to

==========
Use LayoutObject::selectionState() to check whether selection contains node or
not

This patch changes |FrameSelection::respondToNodeModification()| to check
whether node to be removed in selection or not by using value of
|LayoutObject::selectionState()| instead of using |Range::intersectsNode()| to
make node removal faster.

Execution time of attached performance test on my local PC:
Before: 3.80ms
After: 2.92ms

BUG=63233
TEST=PerformanceTests/DOM/remove_child_with_selection.html
==========

[yosin_UTC9, 2016-08-05 06:51:29]

Description was changed from

==========
Use LayoutObject::selectionState() to check whether selection contains node or
not

This patch changes |FrameSelection::respondToNodeModification()| to check
whether node to be removed in selection or not by using value of
|LayoutObject::selectionState()| instead of using |Range::intersectsNode()| to
make node removal faster.

Execution time of attached performance test on my local PC:
Before: 3.80ms
After: 2.92ms

BUG=63233
TEST=PerformanceTests/DOM/remove_child_with_selection.html
==========

to

==========
Use LayoutObject::selectionState() to check whether selection contains node or
not

This patch changes |FrameSelection::respondToNodeModification()| to check
whether node to be removed in selection or not by using value of
|LayoutObject::selectionState()| instead of using |Range::intersectsNode()| to
make node removal faster.

Execution time of attached performance test on my local PC:
Before: 3.80ms
After: 2.92ms

BUG=259874, 632333
TEST=PerformanceTests/DOM/remove_child_with_selection.html
==========

[yosin_UTC9, 2016-08-05 07:35:27]

Description was changed from

==========
Use LayoutObject::selectionState() to check whether selection contains node or
not

This patch changes |FrameSelection::respondToNodeModification()| to check
whether node to be removed in selection or not by using value of
|LayoutObject::selectionState()| instead of using |Range::intersectsNode()| to
make node removal faster.

Execution time of attached performance test on my local PC:
Before: 3.80ms
After: 2.92ms

BUG=259874, 632333
TEST=PerformanceTests/DOM/remove_child_with_selection.html
==========

to

==========
Use LayoutObject::selectionState() to check whether selection contains node or
not

This patch changes |FrameSelection::respondToNodeModification()| to check
whether node to be removed in selection or not by using value of
|LayoutObject::selectionState()| instead of using |Range::intersectsNode()| to
make node removal faster.

Execution time of attached performance test on my local PC:
Before: 3.80ms
After: 2.92ms

BUG=259874, 505335, 632333
TEST=PerformanceTests/DOM/remove_child_with_selection.html
==========

[commit-bot: I haz the power, 2016-08-05 07:45:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 07:45:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2016-08-08 01:29:52]

Description was changed from

==========
Use LayoutObject::selectionState() to check whether selection contains node or
not

This patch changes |FrameSelection::respondToNodeModification()| to check
whether node to be removed in selection or not by using value of
|LayoutObject::selectionState()| instead of using |Range::intersectsNode()| to
make node removal faster.

Execution time of attached performance test on my local PC:
Before: 3.80ms
After: 2.92ms

BUG=259874, 505335, 632333
TEST=PerformanceTests/DOM/remove_child_with_selection.html
==========

to

==========
Use LayoutObject::selectionState() to check whether selection contains node or
not

This patch changes |FrameSelection::respondToNodeModification()| to check
whether node to be removed in selection or not by using value of
|LayoutObject::selectionState()| instead of using |Range::intersectsNode()| to
make node removal faster.

Execution time of attached performance test on my local PC:
Before: 3.80ms
After: 2.92ms

BUG=259874, 505335, 632333
TEST=PerformanceTests/DOM/remove_child_with_selection.html

# Failed tests on 2016-08-05T15:40:43
- fast/repaint/selection-after-remove.html
-
imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-empty-001b.html
==========

[yosin_UTC9, 2016-08-08 02:12:41]

Description was changed from

==========
Use LayoutObject::selectionState() to check whether selection contains node or
not

This patch changes |FrameSelection::respondToNodeModification()| to check
whether node to be removed in selection or not by using value of
|LayoutObject::selectionState()| instead of using |Range::intersectsNode()| to
make node removal faster.

Execution time of attached performance test on my local PC:
Before: 3.80ms
After: 2.92ms

BUG=259874, 505335, 632333
TEST=PerformanceTests/DOM/remove_child_with_selection.html

# Failed tests on 2016-08-05T15:40:43
- fast/repaint/selection-after-remove.html
-
imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-empty-001b.html
==========

to

==========
Use LayoutObject::selectionState() to check whether selection contains node or
not

This patch changes |FrameSelection::respondToNodeModification()| to check
whether node to be removed in selection or not by using value of
|LayoutObject::selectionState()| instead of using |Range::intersectsNode()| to
make node removal faster.

Execution time of attached performance test on my local PC:
Before: 3.80ms
After: 2.92ms

"fast/repaint/selection-after-remove.html" needs rebaseline since this patch
reduce invalidate elements. Following lines are removed from test expectation
text:
     {
      "object": "LayoutBlockFlow HTML",
      "reason": "selection"
    },
    {
      "object": "LayoutBlockFlow BODY",
      "reason": "selection"
    },

BUG=259874, 505335, 632333
TEST=PerformanceTests/DOM/remove_child_with_selection.html
==========

[yosin_UTC9, 2016-08-08 02:14:59]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 02:15:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-08-08 02:20:32]

Description was changed from

==========
Use LayoutObject::selectionState() to check whether selection contains node or
not

This patch changes |FrameSelection::respondToNodeModification()| to check
whether node to be removed in selection or not by using value of
|LayoutObject::selectionState()| instead of using |Range::intersectsNode()| to
make node removal faster.

Execution time of attached performance test on my local PC:
Before: 3.80ms
After: 2.92ms

"fast/repaint/selection-after-remove.html" needs rebaseline since this patch
reduce invalidate elements. Following lines are removed from test expectation
text:
     {
      "object": "LayoutBlockFlow HTML",
      "reason": "selection"
    },
    {
      "object": "LayoutBlockFlow BODY",
      "reason": "selection"
    },

BUG=259874, 505335, 632333
TEST=PerformanceTests/DOM/remove_child_with_selection.html
==========

to

==========
Use LayoutObject::selectionState() to check whether selection contains node or
not

This patch changes |FrameSelection::respondToNodeModification()| to check
whether node to be removed in selection or not by using value of
|LayoutObject::selectionState()| instead of using |Range::intersectsNode()| to
make node removal faster.

Execution time of attached performance test on my local PC:
Before: 3.80ms
After: 2.92ms

"fast/repaint/selection-after-remove.html" needs rebaseline since this patch
reduce invalidate elements, e.g. HTML and BODY elements aren't invalidated.

BUG=259874, 505335, 632333
TEST=PerformanceTests/DOM/remove_child_with_selection.html
==========

[commit-bot: I haz the power, 2016-08-08 03:54:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 03:54:23]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-08-08 04:30:19]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2016-08-08 04:30:20]

PTAL

[Xiaocheng, 2016-08-08 05:07:31]

lgtm

[yosin_UTC9, 2016-08-08 06:05:49]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-08-08 06:06:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 06:09:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-08 06:11:21]

Description was changed from

==========
Use LayoutObject::selectionState() to check whether selection contains node or
not

This patch changes |FrameSelection::respondToNodeModification()| to check
whether node to be removed in selection or not by using value of
|LayoutObject::selectionState()| instead of using |Range::intersectsNode()| to
make node removal faster.

Execution time of attached performance test on my local PC:
Before: 3.80ms
After: 2.92ms

"fast/repaint/selection-after-remove.html" needs rebaseline since this patch
reduce invalidate elements, e.g. HTML and BODY elements aren't invalidated.

BUG=259874, 505335, 632333
TEST=PerformanceTests/DOM/remove_child_with_selection.html
==========

to

==========
Use LayoutObject::selectionState() to check whether selection contains node or
not

This patch changes |FrameSelection::respondToNodeModification()| to check
whether node to be removed in selection or not by using value of
|LayoutObject::selectionState()| instead of using |Range::intersectsNode()| to
make node removal faster.

Execution time of attached performance test on my local PC:
Before: 3.80ms
After: 2.92ms

"fast/repaint/selection-after-remove.html" needs rebaseline since this patch
reduce invalidate elements, e.g. HTML and BODY elements aren't invalidated.

BUG=259874, 505335, 632333
TEST=PerformanceTests/DOM/remove_child_with_selection.html

Committed: https://crrev.com/3316ab0c51851da3f4ad14a7a273c21b542ba8f4
Cr-Commit-Position: refs/heads/master@{#410308}
==========

[commit-bot: I haz the power, 2016-08-08 06:11:22]

Patchset 2 (id:??) landed as
https://crrev.com/3316ab0c51851da3f4ad14a7a273c21b542ba8f4
Cr-Commit-Position: refs/heads/master@{#410308}