Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.h

Issue 2212163002: Add some plumbing for the color management of canvases (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.h
diff --git a/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.h b/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.h
index e26ca1764eb0402d99e0910c38693232306557fb..54a85540dcf4495ff91a75ebca43f33e10272434 100644
--- a/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.h
+++ b/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.h
@@ -26,10 +26,11 @@ class RecordingImageBufferFallbackSurfaceFactory {
USING_FAST_MALLOC(RecordingImageBufferFallbackSurfaceFactory);
WTF_MAKE_NONCOPYABLE(RecordingImageBufferFallbackSurfaceFactory);
public:
- virtual std::unique_ptr<ImageBufferSurface> createSurface(const IntSize&, OpacityMode) = 0;
+ virtual std::unique_ptr<ImageBufferSurface> createSurface(const IntSize&, OpacityMode, sk_sp<SkColorSpace>) = 0;
virtual ~RecordingImageBufferFallbackSurfaceFactory() { }
protected:
RecordingImageBufferFallbackSurfaceFactory() { }
+private:
chrishtr 2016/08/08 22:04:31 Useless, remove.
Justin Novosad 2016/08/11 19:32:57 Done.
};
class PLATFORM_EXPORT RecordingImageBufferSurface : public ImageBufferSurface {
@@ -39,7 +40,7 @@ public:
// for one frame and should not be used for any operations which need a
// raster surface, (i.e. writePixels).
// Only #getPicture should be used to access the resulting frame.
- RecordingImageBufferSurface(const IntSize&, std::unique_ptr<RecordingImageBufferFallbackSurfaceFactory> fallbackFactory = nullptr, OpacityMode = NonOpaque);
+ RecordingImageBufferSurface(const IntSize&, std::unique_ptr<RecordingImageBufferFallbackSurfaceFactory> fallbackFactory = nullptr, OpacityMode = NonOpaque, sk_sp<SkColorSpace> = nullptr);
~RecordingImageBufferSurface() override;
// Implementation of ImageBufferSurface interfaces

Powered by Google App Engine
This is Rietveld 408576698