third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp - Issue 2212163002: Add some plumbing for the color management of canvases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Issue 2212163002: Add some plumbing for the color management of canvases (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp ('k') | third_party/WebKit/Source/platform/graphics/Canvas2DImageBufferSurface.h » ('j') | third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

index ec3b48206e6f0da15963f01768e62ad4a3a33ec1..b13158517a5a1c177a4bbcd0eec0c68d5de969ac 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

@@ -908,7 +908,7 @@ WebGLRenderingContextBase::WebGLRenderingContextBase(HTMLCanvasElement* passedCa

WebGLRenderingContextBase::WebGLRenderingContextBase(HTMLCanvasElement* passedCanvas,

OffscreenCanvas* passedOffscreenCanvas, std::unique_ptr<WebGraphicsContext3DProvider> contextProvider,

const WebGLContextAttributes& requestedAttributes, unsigned version)

- : CanvasRenderingContext(passedCanvas, passedOffscreenCanvas)

+ : CanvasRenderingContext(passedCanvas, passedOffscreenCanvas, "")

chrishtr 2016/08/08 22:04:31 No namespace?

chrishtr 2016/08/08 22:04:50 s/namespace/colorspace/

Justin Novosad 2016/08/11 19:32:57 My intention is to land in two phases. Phase two w

, m_isHidden(false)

, m_contextLostMode(NotLostContext)

, m_autoRecoveryMethod(Manual)