Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 2212143002: Linux: Add xcb to install-build-deps (Closed)

Created:
4 years, 4 months ago by Tom (Use chromium acct)
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang, Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux: Add xcb to install-build-deps BUG=634085 Committed: https://crrev.com/41f9e395f017af1d8c3c2b51f13e404445ba5f07 Cr-Commit-Position: refs/heads/master@{#409955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M build/experimental/install-build-deps.py View 2 chunks +2 lines, -0 lines 0 comments Download
M build/install-build-deps.sh View 1 chunk +9 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Tom (Use chromium acct)
dpranke for OWNERS approval The install-build-deps.* scripts were partitioned from https://codereview.chromium.org/2163623003 so sysadmins can install ...
4 years, 4 months ago (2016-08-04 22:21:56 UTC) #2
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-04 22:24:09 UTC) #3
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-05 00:07:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2212143002/1
4 years, 4 months ago (2016-08-05 00:17:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 00:51:03 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 00:52:26 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41f9e395f017af1d8c3c2b51f13e404445ba5f07
Cr-Commit-Position: refs/heads/master@{#409955}

Powered by Google App Engine
This is Rietveld 408576698