Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2211973002:
Update skimage VERSION: attempt 3 (Closed)
DescriptionUpdate skimage VERSION: attempt 3
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211973002
Committed: https://skia.googlesource.com/skia/+/6fc699aab71747b2fab1b1c096abfc5f9093247c
Patch Set 1 #Patch Set 2 : Try 4 #
Depends on Patchset: Messages
Total messages: 17 (12 generated)
Description was changed from ========== Update skimage VERSION: attempt 3 BUG=skia: ========== to ========== Update skimage VERSION: attempt 3 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211973002 ==========
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
msarett@google.com changed reviewers: + borenet@google.com
Woohoo this worked! I ended up creating my own directory structure - but more importantly (I think), I started from scratch with images that I already had on my machine (rather than the files from create.py). There has to be a way to make the downloaded files "normal", but I gave up on messing around with chmod/chown etc.
On 2016/08/04 17:06:58, msarett wrote: > Woohoo this worked! > > I ended up creating my own directory structure - but more importantly (I think), > I started from scratch with images that I already had on my machine (rather than > the files from create.py). > > There has to be a way to make the downloaded files "normal", but I gave up on > messing around with chmod/chown etc. LGTM if you're sure you've got the right set of images now. We'll have to work out a better way to automate this.
On 2016/08/04 17:12:01, borenet wrote: > On 2016/08/04 17:06:58, msarett wrote: > > Woohoo this worked! > > > > I ended up creating my own directory structure - but more importantly (I > think), > > I started from scratch with images that I already had on my machine (rather > than > > the files from create.py). > > > > There has to be a way to make the downloaded files "normal", but I gave up on > > messing around with chmod/chown etc. > > LGTM if you're sure you've got the right set of images now. We'll have to work > out a better way to automate this. Agreed, I did a diff to make sure I wasn't messing anything up. FWIW, now that I've set up my own directories, this will be easy next time.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by msarett@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Update skimage VERSION: attempt 3 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211973002 ========== to ========== Update skimage VERSION: attempt 3 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211973002 Committed: https://skia.googlesource.com/skia/+/6fc699aab71747b2fab1b1c096abfc5f9093247c ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/6fc699aab71747b2fab1b1c096abfc5f9093247c |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
