Plugin Power Saver Tiny: Fix Plugin.PowerSaver.PeripheralHeuristic UMA

Plugin Power Saver Tiny: Fix Plugin.PowerSaver.PeripheralHeuristic UMA

Previously, it counted every status query. As we implemented PPS tiny,
the number of queries for tiny plugins increased, but we didn't
enforce that it was only recorded once.

This CL enforces that only the initial decision for a plugin is
recorded. It also migrates the UMA to a
Plugin.PowerSaver.PeripheralHeuristicInitialDecision name to prevent
further confusion.

This is complicated because there are three paths a plugin may follow:

1. Essential origin case. No placeholder, no throttler - Record
   immediately, in PowerSaverInfo.

2. Placeholder spawned first (because PPS tiny or background tab or
   prerendering) - Don't record in PowerSaverInfo. Record in
   LoadablePluginPlaceholder after size known. If a Throttler is
   spawned from the placeholder, tell it to not record.

3. Throttler spawned first - Record in the throttler.

Once PPS Tiny is launched 100%, case #3 can be eliminated.

BUG=634130
Committed: https://crrev.com/8a1ef84d9dab70b79d20b2aa6d07ade20e54d19f
Cr-Commit-Position: refs/heads/master@{#411174}

[tommycli, 2016-08-04 01:30:51]

Description was changed from

==========
Plugin Power Saver Tiny: Fix Plugin.PowerSaver.PeripheralHeuristic UMA

Previously, it counted every status query. As we implemented PPS tiny,
the number of queries for tiny plugins increased, but we didn't enforce
that it was only recorded once.

This CL enforces that only the initial decision for a plugin is
recorded.

BUG=634130
==========

to

==========
Plugin Power Saver Tiny: Fix Plugin.PowerSaver.PeripheralHeuristic UMA

Previously, it counted every status query. As we implemented PPS tiny,
the number of queries for tiny plugins increased, but we didn't enforce
that it was only recorded once.

This CL enforces that only the initial decision for a plugin is
recorded. It also migrates the UMA to a
Plugin.PowerSaver.PeripheralHeuristicInitialDecision name to prevent further
confusion.

BUG=634130
==========

[tommycli, 2016-08-04 01:34:09]

Description was changed from

==========
Plugin Power Saver Tiny: Fix Plugin.PowerSaver.PeripheralHeuristic UMA

Previously, it counted every status query. As we implemented PPS tiny,
the number of queries for tiny plugins increased, but we didn't enforce
that it was only recorded once.

This CL enforces that only the initial decision for a plugin is
recorded. It also migrates the UMA to a
Plugin.PowerSaver.PeripheralHeuristicInitialDecision name to prevent further
confusion.

BUG=634130
==========

to

==========
Plugin Power Saver Tiny: Fix Plugin.PowerSaver.PeripheralHeuristic UMA

Previously, it counted every status query. As we implemented PPS tiny, the
number of queries for tiny plugins increased, but we didn't enforce that it was
only recorded once.

This CL enforces that only the initial decision for a plugin is recorded. It
also migrates the UMA to a Plugin.PowerSaver.PeripheralHeuristicInitialDecision
name to prevent further confusion.

This is complicated because there are three paths a plugin may follow:

1. Essential origin case (don't care about size) - Record immediately, in
PowerSaverInfo.

2. Non-whitelisted cross origin, unknown size, and a placeholder is spawned
first (because PPS tiny or background tab or prerendering) - Don't record in
PowerSaverInfo. Record in LoadablePluginPlaceholder. If a Throttler is spawned
from the placeholder, tell it to not record.

3. Non-whitelisted cross origin, but a throttler is spawned first - Record in
the throttler.

BUG=634130
==========

[tommycli, 2016-08-04 01:34:37]

Description was changed from

==========
Plugin Power Saver Tiny: Fix Plugin.PowerSaver.PeripheralHeuristic UMA

Previously, it counted every status query. As we implemented PPS tiny, the
number of queries for tiny plugins increased, but we didn't enforce that it was
only recorded once.

This CL enforces that only the initial decision for a plugin is recorded. It
also migrates the UMA to a Plugin.PowerSaver.PeripheralHeuristicInitialDecision
name to prevent further confusion.

This is complicated because there are three paths a plugin may follow:

1. Essential origin case (don't care about size) - Record immediately, in
PowerSaverInfo.

2. Non-whitelisted cross origin, unknown size, and a placeholder is spawned
first (because PPS tiny or background tab or prerendering) - Don't record in
PowerSaverInfo. Record in LoadablePluginPlaceholder. If a Throttler is spawned
from the placeholder, tell it to not record.

3. Non-whitelisted cross origin, but a throttler is spawned first - Record in
the throttler.

BUG=634130
==========

to

==========
Plugin Power Saver Tiny: Fix Plugin.PowerSaver.PeripheralHeuristic UMA

Previously, it counted every status query. As we implemented PPS tiny, the
number of queries for tiny plugins increased, but we didn't enforce that it was
only recorded once.

This CL enforces that only the initial decision for a plugin is recorded. It
also migrates the UMA to a Plugin.PowerSaver.PeripheralHeuristicInitialDecision
name to prevent further confusion.

This is complicated because there are three paths a plugin may follow:

1. Essential origin case (don't care about size) - Record immediately, in
PowerSaverInfo.

2. Non-whitelisted cross origin, unknown size, and a placeholder is spawned
first (because PPS tiny or background tab or prerendering) - Don't record in
PowerSaverInfo. Record in LoadablePluginPlaceholder. If a Throttler is spawned
from the placeholder, tell it to not record.

3. Non-whitelisted cross origin, but a throttler is spawned first - Record in
the throttler.

When PPS tiny is always On, Case #3 can be eliminated.

BUG=634130
==========

[tommycli, 2016-08-04 01:35:43]

Description was changed from

==========
Plugin Power Saver Tiny: Fix Plugin.PowerSaver.PeripheralHeuristic UMA

Previously, it counted every status query. As we implemented PPS tiny, the
number of queries for tiny plugins increased, but we didn't enforce that it was
only recorded once.

This CL enforces that only the initial decision for a plugin is recorded. It
also migrates the UMA to a Plugin.PowerSaver.PeripheralHeuristicInitialDecision
name to prevent further confusion.

This is complicated because there are three paths a plugin may follow:

1. Essential origin case (don't care about size) - Record immediately, in
PowerSaverInfo.

2. Non-whitelisted cross origin, unknown size, and a placeholder is spawned
first (because PPS tiny or background tab or prerendering) - Don't record in
PowerSaverInfo. Record in LoadablePluginPlaceholder. If a Throttler is spawned
from the placeholder, tell it to not record.

3. Non-whitelisted cross origin, but a throttler is spawned first - Record in
the throttler.

When PPS tiny is always On, Case #3 can be eliminated.

BUG=634130
==========

to

==========
Plugin Power Saver Tiny: Fix Plugin.PowerSaver.PeripheralHeuristic UMA

Previously, it counted every status query. As we implemented PPS tiny, the
number of queries for tiny plugins increased, but we didn't enforce that it was
only recorded once.

This CL enforces that only the initial decision for a plugin is recorded. It
also migrates the UMA to a Plugin.PowerSaver.PeripheralHeuristicInitialDecision
name to prevent further confusion.

This is complicated because there are three paths a plugin may follow:

1. Essential origin case. No placeholder, no throttler - Record immediately, in
PowerSaverInfo.

2. Placeholder spawned first (because PPS tiny or background tab or
prerendering) - Don't record in PowerSaverInfo. Record in
LoadablePluginPlaceholder after size known. If a Throttler is spawned from the
placeholder, tell it to not record.

3. Throttler spawned first - Record in the throttler.

When PPS tiny is always On, Case #3 can be eliminated.

BUG=634130
==========

[tommycli, 2016-08-04 01:36:04]

Description was changed from

==========
Plugin Power Saver Tiny: Fix Plugin.PowerSaver.PeripheralHeuristic UMA

Previously, it counted every status query. As we implemented PPS tiny, the
number of queries for tiny plugins increased, but we didn't enforce that it was
only recorded once.

This CL enforces that only the initial decision for a plugin is recorded. It
also migrates the UMA to a Plugin.PowerSaver.PeripheralHeuristicInitialDecision
name to prevent further confusion.

This is complicated because there are three paths a plugin may follow:

1. Essential origin case. No placeholder, no throttler - Record immediately, in
PowerSaverInfo.

2. Placeholder spawned first (because PPS tiny or background tab or
prerendering) - Don't record in PowerSaverInfo. Record in
LoadablePluginPlaceholder after size known. If a Throttler is spawned from the
placeholder, tell it to not record.

3. Throttler spawned first - Record in the throttler.

When PPS tiny is always On, Case #3 can be eliminated.

BUG=634130
==========

to

==========
Plugin Power Saver Tiny: Fix Plugin.PowerSaver.PeripheralHeuristic UMA

Previously, it counted every status query. As we implemented PPS tiny, the
number of queries for tiny plugins increased, but we didn't enforce that it was
only recorded once.

This CL enforces that only the initial decision for a plugin is recorded. It
also migrates the UMA to a Plugin.PowerSaver.PeripheralHeuristicInitialDecision
name to prevent further confusion.

This is complicated because there are three paths a plugin may follow:

1. Essential origin case. No placeholder, no throttler - Record immediately, in
PowerSaverInfo.

2. Placeholder spawned first (because PPS tiny or background tab or
prerendering) - Don't record in PowerSaverInfo. Record in
LoadablePluginPlaceholder after size known. If a Throttler is spawned from the
placeholder, tell it to not record.

3. Throttler spawned first - Record in the throttler.

Once PPS Tiny is launched 100%, case #3 can be eliminated.

BUG=634130
==========

[tommycli, 2016-08-04 01:36:17]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 01:37:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 03:08:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 03:08:01]

Dry run: This issue passed the CQ dry run.

[tommycli, 2016-08-04 16:10:53]

tommycli@chromium.org changed reviewers:
+ groby@chromium.org

[tommycli, 2016-08-04 16:10:53]

groby: PTAL, this fixes the heuristic to only count once. It's a bit complicated
with three possible cases I mentioned in the CL description.

[groby-ooo-7-16, 2016-08-05 21:16:52]

What happens on size change?

https://codereview.chromium.org/2211753002/diff/1/chrome/renderer/chrome_cont...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/2211753002/diff/1/chrome/renderer/chrome_cont...
chrome/renderer/chrome_content_renderer_client.cc:797:
PluginInstanceThrottler::Create(true /* record_decision */);
Please use enum instead of true/false with comments.

I.e. Create(RECORD_DECISION) or Create(DONT_RECORD_DECISION)

[tommycli, 2016-08-08 17:37:39]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 17:38:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-08-08 18:02:02]

groby: Thanks.

Size change is handled in here:
https://codereview.chromium.org/2211753002/diff/20001/components/plugins/rend...

It

https://codereview.chromium.org/2211753002/diff/1/chrome/renderer/chrome_cont...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/2211753002/diff/1/chrome/renderer/chrome_cont...
chrome/renderer/chrome_content_renderer_client.cc:797:
PluginInstanceThrottler::Create(true /* record_decision */);
On 2016/08/05 21:16:52, groby wrote:
> Please use enum instead of true/false with comments.
> 
> I.e. Create(RECORD_DECISION) or Create(DONT_RECORD_DECISION)

Done.

[tommycli, 2016-08-08 18:02:26]

On 2016/08/08 18:02:02, tommycli wrote:
> groby: Thanks.
> 
> Size change is handled in here:
>
https://codereview.chromium.org/2211753002/diff/20001/components/plugins/rend...
> 
> It
> 
>
https://codereview.chromium.org/2211753002/diff/1/chrome/renderer/chrome_cont...
> File chrome/renderer/chrome_content_renderer_client.cc (right):
> 
>
https://codereview.chromium.org/2211753002/diff/1/chrome/renderer/chrome_cont...
> chrome/renderer/chrome_content_renderer_client.cc:797:
> PluginInstanceThrottler::Create(true /* record_decision */);
> On 2016/08/05 21:16:52, groby wrote:
> > Please use enum instead of true/false with comments.
> > 
> > I.e. Create(RECORD_DECISION) or Create(DONT_RECORD_DECISION)
> 
> Done.

On size change, it's only recorded if heuristic_run_before_ is false. Thanks.

[commit-bot: I haz the power, 2016-08-08 18:39:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 18:39:15]

Dry run: This issue passed the CQ dry run.

[tommycli, 2016-08-10 16:45:05]

On 2016/08/08 18:02:26, tommycli wrote:
> On 2016/08/08 18:02:02, tommycli wrote:
> > groby: Thanks.
> > 
> > Size change is handled in here:
> >
>
https://codereview.chromium.org/2211753002/diff/20001/components/plugins/rend...
> > 
> > It
> > 
> >
>
https://codereview.chromium.org/2211753002/diff/1/chrome/renderer/chrome_cont...
> > File chrome/renderer/chrome_content_renderer_client.cc (right):
> > 
> >
>
https://codereview.chromium.org/2211753002/diff/1/chrome/renderer/chrome_cont...
> > chrome/renderer/chrome_content_renderer_client.cc:797:
> > PluginInstanceThrottler::Create(true /* record_decision */);
> > On 2016/08/05 21:16:52, groby wrote:
> > > Please use enum instead of true/false with comments.
> > > 
> > > I.e. Create(RECORD_DECISION) or Create(DONT_RECORD_DECISION)
> > 
> > Done.
> 
> On size change, it's only recorded if heuristic_run_before_ is false. Thanks.

groby: ping, thanks

[groby-ooo-7-16, 2016-08-10 19:47:14]

LGTM, and thank you.

A small personal request for the future, if I may: If you merge, can you do that
in a completely separate patchset? That way, it's much easier for me to just
review the changes you actually made yourself :)

[tommycli, 2016-08-10 20:36:51]

On 2016/08/10 19:47:14, groby wrote:
> LGTM, and thank you.
> 
> A small personal request for the future, if I may: If you merge, can you do
that
> in a completely separate patchset? That way, it's much easier for me to just
> review the changes you actually made yourself :)

groby: will do. I'll merge in a separate patchset next time. sending it in. thx
for review

[tommycli, 2016-08-10 20:36:57]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-08-10 20:37:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 20:46:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 20:46:41]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tommycli, 2016-08-10 20:48:30]

tommycli@chromium.org changed reviewers:
+ isherman@chromium.org, piman@chromium.org, thestig@chromium.org

[tommycli, 2016-08-10 20:48:33]

isherman: tools/ PTAL
thestig: chrome/ PTAL
piman: content/ PTAL

whew - lots of owner stamps needed. Thanks all!

[Ilya Sherman, 2016-08-10 20:55:28]

metrics lgtm

[piman, 2016-08-10 21:00:19]

lgtm

[Lei Zhang, 2016-08-10 21:34:59]

lgtm, bonus points for wrapping commit messages at 72 cols.

[tommycli, 2016-08-10 21:40:56]

Description was changed from

==========
Plugin Power Saver Tiny: Fix Plugin.PowerSaver.PeripheralHeuristic UMA

Previously, it counted every status query. As we implemented PPS tiny, the
number of queries for tiny plugins increased, but we didn't enforce that it was
only recorded once.

This CL enforces that only the initial decision for a plugin is recorded. It
also migrates the UMA to a Plugin.PowerSaver.PeripheralHeuristicInitialDecision
name to prevent further confusion.

This is complicated because there are three paths a plugin may follow:

1. Essential origin case. No placeholder, no throttler - Record immediately, in
PowerSaverInfo.

2. Placeholder spawned first (because PPS tiny or background tab or
prerendering) - Don't record in PowerSaverInfo. Record in
LoadablePluginPlaceholder after size known. If a Throttler is spawned from the
placeholder, tell it to not record.

3. Throttler spawned first - Record in the throttler.

Once PPS Tiny is launched 100%, case #3 can be eliminated.

BUG=634130
==========

to

==========
Plugin Power Saver Tiny: Fix Plugin.PowerSaver.PeripheralHeuristic UMA

Previously, it counted every status query. As we implemented PPS tiny, 
the number of queries for tiny plugins increased, but we didn't 
enforce that it was only recorded once.

This CL enforces that only the initial decision for a plugin is 
recorded. It also migrates the UMA to a 
Plugin.PowerSaver.PeripheralHeuristicInitialDecision name to prevent 
further confusion.

This is complicated because there are three paths a plugin may follow:

1. Essential origin case. No placeholder, no throttler - Record 
   immediately, in PowerSaverInfo.

2. Placeholder spawned first (because PPS tiny or background tab or 
   prerendering) - Don't record in PowerSaverInfo. Record in 
   LoadablePluginPlaceholder after size known. If a Throttler is 
   spawned from the placeholder, tell it to not record.

3. Throttler spawned first - Record in the throttler.

Once PPS Tiny is launched 100%, case #3 can be eliminated.

BUG=634130
==========

[tommycli, 2016-08-10 21:41:40]

wrapped!

thanks all.

[tommycli, 2016-08-10 21:41:52]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-08-10 21:43:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 23:06:27]

Description was changed from

==========
Plugin Power Saver Tiny: Fix Plugin.PowerSaver.PeripheralHeuristic UMA

Previously, it counted every status query. As we implemented PPS tiny, 
the number of queries for tiny plugins increased, but we didn't 
enforce that it was only recorded once.

This CL enforces that only the initial decision for a plugin is 
recorded. It also migrates the UMA to a 
Plugin.PowerSaver.PeripheralHeuristicInitialDecision name to prevent 
further confusion.

This is complicated because there are three paths a plugin may follow:

1. Essential origin case. No placeholder, no throttler - Record 
   immediately, in PowerSaverInfo.

2. Placeholder spawned first (because PPS tiny or background tab or 
   prerendering) - Don't record in PowerSaverInfo. Record in 
   LoadablePluginPlaceholder after size known. If a Throttler is 
   spawned from the placeholder, tell it to not record.

3. Throttler spawned first - Record in the throttler.

Once PPS Tiny is launched 100%, case #3 can be eliminated.

BUG=634130
==========

to

==========
Plugin Power Saver Tiny: Fix Plugin.PowerSaver.PeripheralHeuristic UMA

Previously, it counted every status query. As we implemented PPS tiny, 
the number of queries for tiny plugins increased, but we didn't 
enforce that it was only recorded once.

This CL enforces that only the initial decision for a plugin is 
recorded. It also migrates the UMA to a 
Plugin.PowerSaver.PeripheralHeuristicInitialDecision name to prevent 
further confusion.

This is complicated because there are three paths a plugin may follow:

1. Essential origin case. No placeholder, no throttler - Record 
   immediately, in PowerSaverInfo.

2. Placeholder spawned first (because PPS tiny or background tab or 
   prerendering) - Don't record in PowerSaverInfo. Record in 
   LoadablePluginPlaceholder after size known. If a Throttler is 
   spawned from the placeholder, tell it to not record.

3. Throttler spawned first - Record in the throttler.

Once PPS Tiny is launched 100%, case #3 can be eliminated.

BUG=634130
==========

[commit-bot: I haz the power, 2016-08-10 23:06:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-10 23:11:19]

Description was changed from

==========
Plugin Power Saver Tiny: Fix Plugin.PowerSaver.PeripheralHeuristic UMA

Previously, it counted every status query. As we implemented PPS tiny, 
the number of queries for tiny plugins increased, but we didn't 
enforce that it was only recorded once.

This CL enforces that only the initial decision for a plugin is 
recorded. It also migrates the UMA to a 
Plugin.PowerSaver.PeripheralHeuristicInitialDecision name to prevent 
further confusion.

This is complicated because there are three paths a plugin may follow:

1. Essential origin case. No placeholder, no throttler - Record 
   immediately, in PowerSaverInfo.

2. Placeholder spawned first (because PPS tiny or background tab or 
   prerendering) - Don't record in PowerSaverInfo. Record in 
   LoadablePluginPlaceholder after size known. If a Throttler is 
   spawned from the placeholder, tell it to not record.

3. Throttler spawned first - Record in the throttler.

Once PPS Tiny is launched 100%, case #3 can be eliminated.

BUG=634130
==========

to

==========
Plugin Power Saver Tiny: Fix Plugin.PowerSaver.PeripheralHeuristic UMA

Previously, it counted every status query. As we implemented PPS tiny,
the number of queries for tiny plugins increased, but we didn't
enforce that it was only recorded once.

This CL enforces that only the initial decision for a plugin is
recorded. It also migrates the UMA to a
Plugin.PowerSaver.PeripheralHeuristicInitialDecision name to prevent
further confusion.

This is complicated because there are three paths a plugin may follow:

1. Essential origin case. No placeholder, no throttler - Record
   immediately, in PowerSaverInfo.

2. Placeholder spawned first (because PPS tiny or background tab or
   prerendering) - Don't record in PowerSaverInfo. Record in
   LoadablePluginPlaceholder after size known. If a Throttler is
   spawned from the placeholder, tell it to not record.

3. Throttler spawned first - Record in the throttler.

Once PPS Tiny is launched 100%, case #3 can be eliminated.

BUG=634130

Committed: https://crrev.com/8a1ef84d9dab70b79d20b2aa6d07ade20e54d19f
Cr-Commit-Position: refs/heads/master@{#411174}
==========

[commit-bot: I haz the power, 2016-08-10 23:11:20]

Patchset 2 (id:??) landed as
https://crrev.com/8a1ef84d9dab70b79d20b2aa6d07ade20e54d19f
Cr-Commit-Position: refs/heads/master@{#411174}