content/renderer/pepper/plugin_power_saver_helper_browsertest.cc - Issue 2211753002: Plugin Power Saver Tiny: Fix Plugin.PowerSaver.PeripheralHeuristic UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/plugin_power_saver_helper_browsertest.cc

Issue 2211753002: Plugin Power Saver Tiny: Fix Plugin.PowerSaver.PeripheralHeuristic UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge. and change to enum Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/pepper/plugin_power_saver_helper_browsertest.cc

diff --git a/content/renderer/pepper/plugin_power_saver_helper_browsertest.cc b/content/renderer/pepper/plugin_power_saver_helper_browsertest.cc

index 35b8388f88cd2f8d5bdc111104a26b196ae5cf55..91a2df58a4e1bb9bae6dbf501213cd0020846f43 100644

--- a/content/renderer/pepper/plugin_power_saver_helper_browsertest.cc

+++ b/content/renderer/pepper/plugin_power_saver_helper_browsertest.cc

@@ -47,7 +47,8 @@ TEST_F(PluginPowerSaverHelperTest, TemporaryOriginWhitelist) {

EXPECT_EQ(RenderFrame::CONTENT_STATUS_PERIPHERAL,

frame()->GetPeripheralContentStatus(

url::Origin(GURL("http://same.com")),

- url::Origin(GURL("http://other.com")), gfx::Size(100, 100)));

+ url::Origin(GURL("http://other.com")), gfx::Size(100, 100),

+ RenderFrame::DONT_RECORD_DECISION));

// Clear out other messages so we find just the plugin power saver IPCs.

sink_->ClearMessages();

@@ -57,7 +58,8 @@ TEST_F(PluginPowerSaverHelperTest, TemporaryOriginWhitelist) {

EXPECT_EQ(RenderFrame::CONTENT_STATUS_ESSENTIAL_CROSS_ORIGIN_WHITELISTED,

frame()->GetPeripheralContentStatus(

url::Origin(GURL("http://same.com")),

- url::Origin(GURL("http://other.com")), gfx::Size(100, 100)));

+ url::Origin(GURL("http://other.com")), gfx::Size(100, 100),

+ RenderFrame::DONT_RECORD_DECISION));

// Test that we've sent an IPC to the browser.

ASSERT_EQ(1u, sink_->message_count());

@@ -89,14 +91,16 @@ TEST_F(PluginPowerSaverHelperTest, ClearWhitelistOnNavigate) {

EXPECT_EQ(RenderFrame::CONTENT_STATUS_ESSENTIAL_CROSS_ORIGIN_WHITELISTED,

frame()->GetPeripheralContentStatus(

url::Origin(GURL("http://same.com")),

- url::Origin(GURL("http://other.com")), gfx::Size(100, 100)));

+ url::Origin(GURL("http://other.com")), gfx::Size(100, 100),

+ RenderFrame::DONT_RECORD_DECISION));

LoadHTML("<html></html>");

EXPECT_EQ(RenderFrame::CONTENT_STATUS_PERIPHERAL,

frame()->GetPeripheralContentStatus(

url::Origin(GURL("http://same.com")),

- url::Origin(GURL("http://other.com")), gfx::Size(100, 100)));

+ url::Origin(GURL("http://other.com")), gfx::Size(100, 100),

+ RenderFrame::DONT_RECORD_DECISION));

}

} // namespace content

« no previous file with comments | « content/renderer/pepper/plugin_power_saver_helper.cc ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »