Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 221173010: Fixing cr-bash-helpers.sh for zsh. (Closed)

Created:
6 years, 8 months ago by qsr
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/cr/cr-bash-helpers.sh View 1 chunk +3 lines, -3 lines 1 comment Download

Messages

Total messages: 10 (0 generated)
qsr
6 years, 8 months ago (2014-04-02 15:54:54 UTC) #1
Miguel Garcia
lgtm https://chromiumcodereview.appspot.com/221173010/diff/1/tools/cr/cr-bash-helpers.sh File tools/cr/cr-bash-helpers.sh (right): https://chromiumcodereview.appspot.com/221173010/diff/1/tools/cr/cr-bash-helpers.sh#newcode22 tools/cr/cr-bash-helpers.sh:22: cr_base_dir=$(dirname $(${READLINK_e[@]} "${BASH_SOURCE:-$0}")) I assume you have tested ...
6 years, 8 months ago (2014-04-02 16:06:14 UTC) #2
qsr
On 2014/04/02 16:06:14, Miguel Garcia wrote: > lgtm > > https://chromiumcodereview.appspot.com/221173010/diff/1/tools/cr/cr-bash-helpers.sh > File tools/cr/cr-bash-helpers.sh (right): ...
6 years, 8 months ago (2014-04-02 16:26:41 UTC) #3
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 8 months ago (2014-04-03 11:20:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/221173010/1
6 years, 8 months ago (2014-04-03 11:20:32 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 14:59:25 UTC) #6
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 14:59:25 UTC) #7
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 8 months ago (2014-04-03 15:03:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/221173010/1
6 years, 8 months ago (2014-04-03 15:05:51 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 15:10:20 UTC) #10
Message was sent while issue was closed.
Change committed as 261403

Powered by Google App Engine
This is Rietveld 408576698