tools/cr/cr-bash-helpers.sh - Issue 221173010: Fixing cr-bash-helpers.sh for zsh.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/cr/cr-bash-helpers.sh

Issue 221173010: Fixing cr-bash-helpers.sh for zsh. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/cr/cr-bash-helpers.sh

diff --git a/tools/cr/cr-bash-helpers.sh b/tools/cr/cr-bash-helpers.sh

index 9e57b419ff2ef535a3b749242a05d3ad0b0b7e3a..e7e7593df2fb4b53496d3a774c270253257f2553 100755

--- a/tools/cr/cr-bash-helpers.sh

+++ b/tools/cr/cr-bash-helpers.sh

@@ -14,12 +14,12 @@ if [[ -n "$BASH_VERSION" && "${BASH_SOURCE:-$0}" == "$0" ]]; then

exit 1

-READLINK_e="readlink -e"

+READLINK_e=("readlink" "-e")

if [[ -x `which greadlink` ]]; then

- READLINK_e="greadlink -e"

+ READLINK_e=("greadlink" "-e")

-cr_base_dir=$(dirname $($READLINK_e "${BASH_SOURCE:-$0}"))

+cr_base_dir=$(dirname $(${READLINK_e[@]} "${BASH_SOURCE:-$0}"))

Miguel Garcia 2014/04/02 16:06:15 I assume you have tested this on bash too?

cr_main="${cr_base_dir}/main.py"

cr_exec=("PYTHONDONTWRITEBYTECODE=1" "python" "${cr_main}")

« no previous file with comments | « no previous file | no next file » | no next file with comments »