Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2211663002:
[MD settings] apply dropdown settings to iron-dropdown (Closed)
|
Created:
4 years, 4 months ago by dschuyler Modified:
4 years, 4 months ago Reviewers:
dpapad CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] apply dropdown settings to iron-dropdown
This CL applies the recent css changes for paper-dropdown-menu to
iron-dropdown.
BUG=634174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/b1dadf84a32ef43688ac2ebd92151f42b3697a70
Cr-Commit-Position: refs/heads/master@{#409695}
Patch Set 1 #
Total comments: 3
Patch Set 2 : symetric padding #Messages
Total messages: 18 (10 generated)
Description was changed from ========== [MD settings] apply dropdown settings to iron-dropdown This CL applies the recent css changes for paper-dropdown-menu to iron-dropdown. BUG=634174 ========== to ========== [MD settings] apply dropdown settings to iron-dropdown This CL applies the recent css changes for paper-dropdown-menu to iron-dropdown. BUG=634174 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
dschuyler@chromium.org changed reviewers: + dpapad@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2211663002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_shared_css.html (right): https://codereview.chromium.org/2211663002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_shared_css.html:52: -webkit-padding-start: 24px; Is it intentional to have a different padding on the left VS the right (which was introduced in the original CL https://codereview.chromium.org/2207773002)? It seems a bit odd when the text is long, because it is closer to the right than the left, see for example http://imgur.com/a/EHoOL.
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2211663002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_shared_css.html (right): https://codereview.chromium.org/2211663002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_shared_css.html:52: -webkit-padding-start: 24px; On 2016/08/03 23:28:17, dpapad wrote: > Is it intentional to have a different padding on the left VS the right (which > was introduced in the original CL https://codereview.chromium.org/2207773002) > It seems a bit odd when the text is long, because it is closer to the right than > the left, see for example http://imgur.com/a/EHoOL. How about having the same padding on both sides?
https://codereview.chromium.org/2211663002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_shared_css.html (right): https://codereview.chromium.org/2211663002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_shared_css.html:52: -webkit-padding-start: 24px; On 2016/08/03 at 23:39:53, dschuyler wrote: > On 2016/08/03 23:28:17, dpapad wrote: > > Is it intentional to have a different padding on the left VS the right (which > > was introduced in the original CL https://codereview.chromium.org/2207773002) > > It seems a bit odd when the text is long, because it is closer to the right than > > the left, see for example http://imgur.com/a/EHoOL. > > How about having the same padding on both sides? It would look better for the case of long text I think.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [MD settings] apply dropdown settings to iron-dropdown This CL applies the recent css changes for paper-dropdown-menu to iron-dropdown. BUG=634174 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] apply dropdown settings to iron-dropdown This CL applies the recent css changes for paper-dropdown-menu to iron-dropdown. BUG=634174 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b1dadf84a32ef43688ac2ebd92151f42b3697a70 Cr-Commit-Position: refs/heads/master@{#409695} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b1dadf84a32ef43688ac2ebd92151f42b3697a70 Cr-Commit-Position: refs/heads/master@{#409695} |
