Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2207773002: [MD settings] layout of paper dropdown menu list to better match mocks (Closed)

Created:
4 years, 4 months ago by dschuyler
Modified:
4 years, 4 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] layout of paper dropdown menu list to better match mocks This CL makes the common dropdown list a little wider and the elements a little shorter. There is also some leading padding. These changes more closely match the mocks. BUG=628001 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/5a33eca041605fb4206fe7dada53ba2ad87e270e Cr-Commit-Position: refs/heads/master@{#409431}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/resources/settings/settings_shared_css.html View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
dschuyler
4 years, 4 months ago (2016-08-03 00:29:36 UTC) #5
dschuyler
4 years, 4 months ago (2016-08-03 00:29:56 UTC) #6
stevenjb
lgtm
4 years, 4 months ago (2016-08-03 02:04:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207773002/1
4 years, 4 months ago (2016-08-03 02:06:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 02:09:56 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 02:12:29 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a33eca041605fb4206fe7dada53ba2ad87e270e
Cr-Commit-Position: refs/heads/master@{#409431}

Powered by Google App Engine
This is Rietveld 408576698