Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2211593002: Cleanup references to concurrent_links in gn binary. (Closed)

Created:
4 years, 4 months ago by sdefresne
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@concurrent_links
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup references to concurrent_links in gn binary. Explicit pool are recommended and concurrent_links is deprecated. Remove concurrent_links support as it should no longer be used. BUG=612786 Committed: https://crrev.com/662a802270f017a00bc870f12866b8f581596d79 Cr-Commit-Position: refs/heads/master@{#409909}

Patch Set 1 #

Patch Set 2 : Fix unittests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -63 lines) Patch
M tools/gn/docs/reference.md View 3 chunks +1 line, -16 lines 0 comments Download
M tools/gn/function_toolchain.cc View 3 chunks +0 lines, -31 lines 0 comments Download
M tools/gn/ninja_build_writer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/gn/ninja_build_writer_unittest.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M tools/gn/toolchain.h View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/gn/toolchain.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
sdefresne
Please take a look.
4 years, 4 months ago (2016-08-03 21:34:08 UTC) #4
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-03 22:06:24 UTC) #6
brettw
lgtm
4 years, 4 months ago (2016-08-03 22:15:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2211593002/20001
4 years, 4 months ago (2016-08-04 21:15:44 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-04 21:55:13 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 21:56:53 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/662a802270f017a00bc870f12866b8f581596d79
Cr-Commit-Position: refs/heads/master@{#409909}

Powered by Google App Engine
This is Rietveld 408576698