Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: tools/gn/function_toolchain.cc

Issue 2211593002: Cleanup references to concurrent_links in gn binary. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@concurrent_links
Patch Set: Fix unittests. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/docs/reference.md ('k') | tools/gn/ninja_build_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/function_toolchain.cc
diff --git a/tools/gn/function_toolchain.cc b/tools/gn/function_toolchain.cc
index 3501ec128a064a7ed86e822970e4a4a5af859cac..faa190e66e46c30c8719b3acd56bcaf632f1f440 100644
--- a/tools/gn/function_toolchain.cc
+++ b/tools/gn/function_toolchain.cc
@@ -332,20 +332,6 @@ const char kToolchain_Help[] =
" requires a lot of duplicate of rules) so should only be used when\n"
" absolutely necessary.\n"
"\n"
- " concurrent_links\n"
- " In integer expressing the number of links that Ninja will perform in\n"
- " parallel. GN will create a pool for shared library and executable\n"
- " link steps with this many processes. Since linking is memory- and\n"
- " I/O-intensive, projects with many large targets may want to limit\n"
- " the number of parallel steps to avoid overloading the computer.\n"
- " Since creating static libraries is generally not as intensive\n"
- " there is no limit to \"alink\" steps.\n"
- "\n"
- " Defaults to 0 which Ninja interprets as \"no limit\".\n"
- "\n"
- " The value used will be the one from the default toolchain of the\n"
- " current build.\n"
- "\n"
"Invoking targets in toolchains:\n"
"\n"
" By default, when a target depends on another, there is an implicit\n"
@@ -370,8 +356,6 @@ const char kToolchain_Help[] =
"\n"
"Example:\n"
" toolchain(\"plugin_toolchain\") {\n"
- " concurrent_links = 8\n"
- "\n"
" tool(\"cc\") {\n"
" command = \"gcc {{source}}\"\n"
" ...\n"
@@ -428,21 +412,6 @@ Value RunToolchain(Scope* scope,
return Value();
}
- // Read concurrent_links (if any).
- const Value* concurrent_links_value =
- block_scope.GetValue("concurrent_links", true);
- if (concurrent_links_value) {
- if (!concurrent_links_value->VerifyTypeIs(Value::INTEGER, err))
- return Value();
- if (concurrent_links_value->int_value() < 0 ||
- concurrent_links_value->int_value() > std::numeric_limits<int>::max()) {
- *err = Err(*concurrent_links_value, "Value out of range.");
- return Value();
- }
- toolchain->set_concurrent_links(
- static_cast<int>(concurrent_links_value->int_value()));
- }
-
if (!block_scope.CheckForUnusedVars(err))
return Value();
« no previous file with comments | « tools/gn/docs/reference.md ('k') | tools/gn/ninja_build_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698