Make Mac-port non-blocking.

Make Mac-port non-blocking.

Fixes issue #26790.

BUG= http://dartbug.com/26790
R=sgjesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/b8c12bc9ffb2de95e5470c0e65dfdfb8397fdeee

[floitsch, 2016-08-03 20:37:35]

Description was changed from

==========
Make Mac-port non-blocking.
==========

to

==========
Make Mac-port non-blocking.

Fixes issue #26790.

BUG= http://dartbug.com/26790
==========

[floitsch, 2016-08-03 20:37:51]

floitsch@google.com changed reviewers:
+ sgjesse@google.com

[Søren Gjesse, 2016-08-04 06:35:49]

https://codereview.chromium.org/2211523002/diff/20001/runtime/bin/socket_maco...
File runtime/bin/socket_macos.cc (right):

https://codereview.chromium.org/2211523002/diff/20001/runtime/bin/socket_maco...
runtime/bin/socket_macos.cc:102: FDUtils::SetNonBlocking(fd);
I think moving it to Create would be better - then it is only needed once. This
is what is done in the Linux version, where the OS create support a flag for
making the socket non-blocking.

[floitsch, 2016-08-04 12:17:07]

PTAL.

https://codereview.chromium.org/2211523002/diff/20001/runtime/bin/socket_maco...
File runtime/bin/socket_macos.cc (right):

https://codereview.chromium.org/2211523002/diff/20001/runtime/bin/socket_maco...
runtime/bin/socket_macos.cc:102: FDUtils::SetNonBlocking(fd);
On 2016/08/04 06:35:49, Søren Gjesse wrote:
> I think moving it to Create would be better - then it is only needed once.
This
> is what is done in the Linux version, where the OS create support a flag for
> making the socket non-blocking.

Done.

[Søren Gjesse, 2016-08-04 13:40:29]

LGTM!

https://codereview.chromium.org/2211523002/diff/40001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2211523002/diff/40001/CHANGELOG.md#newcode6
CHANGELOG.md:6: * `Socket.connect` with source-address argument is now
non-blocking.
This is "on Mac as well"

[floitsch, 2016-08-04 13:58:25]

Description was changed from

==========
Make Mac-port non-blocking.

Fixes issue #26790.

BUG= http://dartbug.com/26790
==========

to

==========
Make Mac-port non-blocking.

Fixes issue #26790.

BUG= http://dartbug.com/26790
R=sgjesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b8c12bc9ffb2de95e5470c0e65dfdfb8397fdeee
==========

[floitsch, 2016-08-04 13:58:26]

Committed patchset #4 (id:60001) manually as
b8c12bc9ffb2de95e5470c0e65dfdfb8397fdeee (presubmit successful).

[floitsch, 2016-08-04 13:59:18]

https://codereview.chromium.org/2211523002/diff/40001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2211523002/diff/40001/CHANGELOG.md#newcode6
CHANGELOG.md:6: * `Socket.connect` with source-address argument is now
non-blocking.
On 2016/08/04 13:40:29, Søren Gjesse wrote:
> This is "on Mac as well"

Changed to: 

`Socket.connect` with source-address argument is now non-blocking
    on Mac. Was already non-blocking on all other platforms.

done.